splash screen dark mode fixed #2482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> so, i added one dark mode colors file in values. -> now any dark mode related work can be done there. -> also fixed splash screen dark mode issue.
|
Hey @KUSHAL-RAJ-PAREEK this isn't the right way to open any PR. This issue was assigned to someone else and you opened it without his consent. Moreover i would urge you to go through the CONTRIBUTING.md and README.md before raising any PR. Now , I will close this PR but obviously you can reopen it if the assignee passes the issue to you. And in case he does allow you to work on it then you may want to consider the fact that we have our own UI library, so we dont really need |
|
I am sorry for that, but can you tell me how to work with you library ?
…On Fri, 12 Jan 2024 at 11:53 PM, Pratyush Singh ***@***.***> wrote:
Closed #2482 <#2482>.
—
Reply to this email directly, view it on GitHub
<#2482 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3SEYBY5Q7YHALIEM62JRGDYOF5THAVCNFSM6AAAAABBYLSD36VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ3TENBWGM3DMMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ok I got it.
On Sat, 13 Jan 2024 at 12:01 AM, Kushal raj Pareek <
***@***.***> wrote:
… I am sorry for that, but can you tell me how to work with you library ?
On Fri, 12 Jan 2024 at 11:53 PM, Pratyush Singh ***@***.***>
wrote:
> Closed #2482 <#2482>.
>
> —
> Reply to this email directly, view it on GitHub
> <#2482 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3SEYBY5Q7YHALIEM62JRGDYOF5THAVCNFSM6AAAAABBYLSD36VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ3TENBWGM3DMMY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2466
fixed dark mode splash screen.
WhatsApp.Video.2024-01-12.at.21.33.23_95e115ea.mp4
-> so, i added one dark mode colors file in values.
-> now any dark mode related work can be done there.
-> also fixed splash screen dark mode issue.