fix: Missing some translation in hindi language #987 #991
Conversation
|
@miPlodder,@therajanmaurya can you please review this PR. |
| @@ -26,7 +26,7 @@ | |||
| <string name="account_balance">खाते में शेष</string> | |||
| <string name="total_deposits">कुल जमा</string> | |||
| <string name="open_drawer">Open Drawer</string> | |||
| <string name="close_drawer">Close Drawer</string> | |||
| <string name="close_drawer">दराज को बंद करें</string> | |||
There was a problem hiding this comment.
This should not be translated, translate=false
There was a problem hiding this comment.
Sorry I did that by mistake. I corrected it now.
| <string name="last_trans">पिछले लेनदेन का विवरण</string> | ||
| <string name="passcode_setup">लॉगिन करने के लिए एक पासकोड सेटअप करें</string> | ||
| <string name="error_fetching_third_party_transfer_template">थर्ड पार्टी ट्रांसफर टेम्प्लेट को लाने में त्रुटि</string> | ||
| <string name="choose">एप्लिकेशन चुनें</string> | ||
|
|
||
| <string name="fetching_client">क्लाइंट ला रहा है</string> | ||
|
|
||
| <string name="not_contain_username">Spaces</string> | ||
| <string name="not_contain_username">रिक्त स्थान</string> |
There was a problem hiding this comment.
Please check in which context this string is used in the application, I feel like It is just to follow non-hardcoded string pattern.
There was a problem hiding this comment.
I resolved it now.
fix: #987 Made suggested changes.
|
@therajanmaurya , I made the suggested changes. Can you please review the PR . |
|
@therajanmaurya can you please review this PR, I made the suggested changes. |
| <string name="double_amount">%1$.2f</string> | ||
| <string name="clear_filters">फिल्टर साफ करे</string> | ||
| <string name="notification">सूचनाएं</string> | ||
| <string name="base_url">आधार यू.आर.ए्ल</string> |
There was a problem hiding this comment.
This string should not be translated.
|
@ShivangiSingh17 please update the PR with the above requested changes. |
|
@prashantkh19 made the suggested changes. |
|
@ShivangiSingh17 can you rebase the branch and fix the travis build error? |
|
Squash your commits also. |
|
@ShivangiSingh17 Closing this PR as there's no update in the recent few months over the review provided by @prashantkh19 :) |
Fixes #987
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.