Removed Profile picture edit button from Profile Fragment #1162
Conversation
| @@ -144,6 +144,8 @@ public void showProfile(Client client) { | |||
| .width((int) getResources().getDimension(R.dimen.user_profile_image_size)) | |||
| .height((int) getResources().getDimension(R.dimen.user_profile_image_size)) | |||
| .endConfig().buildRound(client.getName().substring(0, 1), R.color.colorAccentBlack); | |||
| ImageView editableImageHint=getView().findViewById(R.id.iv_editable_image_hint); | |||
| editableImageHint.setVisibility(View.INVISIBLE); | |||
There was a problem hiding this comment.
Nice one, as I expected, but you didn't checked the ./gradlew check requirement. You should do run that command in your android studio terminal, it helps you to check whether your code style is according to the project style but your changes already passed that test on github PR, so no worries, but keep in mind from now that you run "./gradlew check" command before performing commit because many PR's get stuck in checkstyle test and then you have to make a new commit and squash it, so it's better to do it in first attempt. At last just want to say good on I approve it.
There was a problem hiding this comment.
okay, thanks for the suggestion and review.
|
@devansh-299 please merge it. |
| @@ -144,6 +144,8 @@ public void showProfile(Client client) { | |||
| .width((int) getResources().getDimension(R.dimen.user_profile_image_size)) | |||
| .height((int) getResources().getDimension(R.dimen.user_profile_image_size)) | |||
| .endConfig().buildRound(client.getName().substring(0, 1), R.color.colorAccentBlack); | |||
| ImageView editableImageHint=getView().findViewById(R.id.iv_editable_image_hint); | |||
There was a problem hiding this comment.
Space before and after = is missing, this will lead to failure in lint checks
There was a problem hiding this comment.
@kartikeytyagi15 are u still able to added these mention changes in your PR's commit
There was a problem hiding this comment.
@kartikeytyagi15, @EGOR-IND I think u guys are not able to solves these changes at this time, So Now I am generated new Pr for this particular issue.
Fixes #1158 : Removed profile picture edit button from profile fragment.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.