fix#1252:Display error message if expiry date is invalid #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haran2248
reviewed
Mar 6, 2021
| mDebitCardView.verifyDebitCardError(getContext() | ||
| .getString(R.string.expiry_month_error_message), 2); | ||
| } else if (expiryMonth <= currentMonth && expiryYear == currentYear) { | ||
| mDebitCardView.verifyDebitCardError(getContext() |
There was a problem hiding this comment.
Add a condition if expiryMonth<currentMonth and expiryYear<=currentYear
There was a problem hiding this comment.
Ok, I will surely do that. Should I generate a new pull request after making the required changes? Also I don't know why this pull request failed the static analysis check although on my system it doesn't show any problem.
There was a problem hiding this comment.
@haran2248 I have made the changes you asked for. Can you please review this?
harshhks2
force-pushed
the
dev
branch
2 times, most recently
from
a2b04ba
to
fbd5c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1252
Screenshots
WhatsApp.Video.2021-03-06.at.11.40.56.AM.mp4
Description
Error message is displayed if the expiry date entered by the user is before the current month and/or the current year or the entered year is after 10 years of the current year. Now the user can know and edit if he enters the wrong expiry date by mistake or his debit card has already expired.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.