refactored the fragments of SetupUpiPinActivity to compose screen #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Apr 3, 2024
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/composeScreen/DebitCardScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/composeScreen/DebitCardScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/composeScreen/DebitCardScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/composeScreen/OtpTextField.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/composeScreen/OtpScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/composeScreen/UpiPinScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/fragment/DebitCardFragment.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/fragment/DebitCardFragment.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/fragment/OtpFragment.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/ui/SetupUpiPinActivity.kt
Outdated
Show resolved
Hide resolved
|
@NiranjanNlc adding to @therajanmaurya review, please take into account the following points as well:
|
NiranjanNlc
force-pushed
the
setUpUpi_FragmentsToComposeScreen
branch
from
0250bd1
to
f195a90
Compare
|
@PratyushSingh07 , |
|
@therajanmaurya can this be reviewed again?? |
AdityaKumdale
suggested changes
May 10, 2024
core/ui/src/main/kotlin/org/mifos/mobilewallet/mifospay/ui/HeadingTitile.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/ui/SetupUpiPinActivity.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/screens/OtpScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/screens/SetUpUPiPinScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/screens/UpiPinScreen.kt
Outdated
Show resolved
Hide resolved
mifospay/src/main/java/org/mifos/mobilewallet/mifospay/bank/screens/UpiPinScreen.kt
Outdated
Show resolved
Hide resolved
NiranjanNlc
force-pushed
the
setUpUpi_FragmentsToComposeScreen
branch
from
2f3cb89
to
77aef4c
Compare
NiranjanNlc
force-pushed
the
setUpUpi_FragmentsToComposeScreen
branch
from
77aef4c
to
f72f7d7
Compare
PratyushSingh07
requested changes
Jun 5, 2024
| .fillMaxWidth() | ||
| .padding(8.dp), verticalAlignment = Alignment.Bottom | ||
| ) { | ||
| BasicTextField(modifier = Modifier |
There was a problem hiding this comment.
can we use MFoutlined text field?
| } | ||
|
|
||
| @Composable | ||
| fun CharView2( |
There was a problem hiding this comment.
Give an appropriate name
Comment on lines
+169
to
+171
| fun showToast(context: Context, message: String?) { | ||
| Toaster.showToast(context, message) | ||
| } |
There was a problem hiding this comment.
use compose snackbar
Comment on lines
+44
to
+54
| fun setupUpiPinSuccess(mSetupUpiPin: String?) { | ||
| setUpViewModel.setupUpiPin(bankAccountDetails, mSetupUpiPin) | ||
| bankAccountDetails!!.isUpiEnabled = true | ||
| bankAccountDetails!!.upiPin = mSetupUpiPin | ||
| Toaster.showToast(this, Constants.UPI_PIN_SETUP_COMPLETED_SUCCESSFULLY) | ||
| val intent = Intent() | ||
| intent.putExtra(Constants.UPDATED_BANK_ACCOUNT, bankAccountDetails) | ||
| intent.putExtra(Constants.INDEX, index) | ||
| setResult(RESULT_OK, intent) | ||
| finish() | ||
| } |
There was a problem hiding this comment.
this should have been handled in the compose UI itself
mifospay/src/main/java/org/mifospay/bank/setupUpi/screens/SetUpUpiScreenContent.kt
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1596 and #1597
Screenshots
Screenshot.mp4
Description
Using the bottom to top approach ,
I was refacoring the fragments of SetupUpiPinActivity to consume compose screen , now migrated whole SetupUpiPinActivity to compose screen
I could not go up to bank activity , so I am testing UI by making some change on the existing activity only .
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.