Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use prettier for javascript #2208

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rhopman
Copy link
Contributor

@rhopman rhopman commented Nov 28, 2024

Description

Stop ignoring .js and .json files in prettier and fix existing issues.

The prettier-plugin-multiline-arrays plugin is used to split arrays with multiple elements into one line per element.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@rhopman rhopman force-pushed the use-prettier-for-javascript branch from 7b90b41 to 0d3fa64 Compare November 29, 2024 11:20
@adamsaghy
Copy link
Collaborator

@rhopman Sorry for checking this PR just now. Kindly resolve the conflicts and i will try to merge it into ;)

@rhopman rhopman force-pushed the use-prettier-for-javascript branch from 0d3fa64 to e36ab0e Compare December 19, 2024 09:10
Stop ignoring .js and .json files in prettier and fix existing issues.

The `prettier-plugin-multiline-arrays` plugin is used to split arrays
with multiple elements into one line per element.
@rhopman rhopman force-pushed the use-prettier-for-javascript branch from e36ab0e to 9f38a0d Compare December 19, 2024 09:12
@rhopman
Copy link
Contributor Author

rhopman commented Dec 19, 2024

No worries @adamsaghy! I've resolved the conflicts. Please review whenever you're ready.

@adamsaghy adamsaghy merged commit f693318 into openMF:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants