Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instances with v4 namespace #26

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

ehennestad
Copy link
Collaborator

This change will support loading instances from v4 and later of openMINDS after the namespace was updated ( openMINDS_Instances PR168 )

Copy link

Test Results

462 tests   462 ✅  29s ⏱️
  5 suites    0 💤
  1 files      0 ❌

Results for commit 1de7c8b.

@ehennestad ehennestad self-assigned this Oct 28, 2024
Copy link
Collaborator Author

@ehennestad ehennestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed, code looks ok

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.09%. Comparing base (e5b155e) to head (1de7c8b).

Files with missing lines Patch % Lines
...rnal/+openminds/+internal/+utility/VersionNumber.m 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   31.62%   32.09%   +0.46%     
==========================================
  Files         324      323       -1     
  Lines        3102     3116      +14     
==========================================
+ Hits          981     1000      +19     
+ Misses       2121     2116       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad merged commit 209d3cb into main Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant