Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve test coverage #28

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

ehennestad
Copy link
Collaborator

Only track coverage for schema classes for the latest openMINDS version
Add test that captures string display method of schema classes

Copy link

github-actions bot commented Oct 30, 2024

Test Results

463 tests  ±0   463 ✅ ±0   57s ⏱️ +25s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6b23e2f. ± Comparison against base commit fbc8b6d.

This pull request removes 438 and adds 438 tests. Note that renamed tests count towards both.
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AccountInformation)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=ActionStatusType)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=Affiliation)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AgeCategory)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AmountOfChemical)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AnalysisTechnique)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AnatomicalAxesOrientation)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AnatomicalIdentificationType)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AnatomicalPlane)
testInstanceSaveLoad ‑ testCreateSchema(SchemaType=AnatomicalTargetPosition)
…
InstanceTest ‑ testCreateSchema(SchemaType=AccountInformation)
InstanceTest ‑ testCreateSchema(SchemaType=ActionStatusType)
InstanceTest ‑ testCreateSchema(SchemaType=Affiliation)
InstanceTest ‑ testCreateSchema(SchemaType=AgeCategory)
InstanceTest ‑ testCreateSchema(SchemaType=AmountOfChemical)
InstanceTest ‑ testCreateSchema(SchemaType=AnalysisTechnique)
InstanceTest ‑ testCreateSchema(SchemaType=AnatomicalAxesOrientation)
InstanceTest ‑ testCreateSchema(SchemaType=AnatomicalIdentificationType)
InstanceTest ‑ testCreateSchema(SchemaType=AnatomicalPlane)
InstanceTest ‑ testCreateSchema(SchemaType=AnatomicalTargetPosition)
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.01%. Comparing base (fbc8b6d) to head (6b23e2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   27.04%   37.01%   +9.96%     
==========================================
  Files         722      323     -399     
  Lines        3775     3115     -660     
==========================================
+ Hits         1021     1153     +132     
+ Misses       2754     1962     -792     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad merged commit b7adf56 into main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant