[WIP] Fill Invalid Regions w/ Zero #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filling unwritten/invalid regions, e.g., access outside of written
ADIOS blocks, with not-a-number (NaN) created some confusion.
Technically, data in this region is literally not-a-number (yet), but
it seems easier to process data when it is just filled with zeros
instead.
We now always fill with zeros, hoping that "why is a region empty"
("because it was not written") does not create another kind of
confusion.
Side note: resizing during write of BTD is non-trivial (as in:
not supported by HDF5 and ADIOS), because we need to resize from
the "lower index end". HDF5 and ADIOS only support resizing the
upper index bound.
|
Preferred solution for BTD: Might require an extra openPMD meta-data attribute to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filling unwritten/invalid regions, e.g., access outside of written ADIOS blocks, with not-a-number (NaN) created some confusion: ECP-WarpX/WarpX#4775
Counter-point to this PR:
Technically, data in this region is literally not-a-number (yet). Matplotlib gracefully ignores NaNs for plotting, and can be configured to mask one way or the other with color. Padding with zeros is ambiguous: maybe data was not written, maybe data was written and truly zero.
We now always fill with zeros, hoping that "why is a region empty" ("because it was not written") does not create another kind of confusion.
Side note: resizing during write of BTD is non-trivial (as in: not supported by HDF5 and ADIOS), because we need to resize from the "lower index end". HDF5 and ADIOS only support resizing the upper index bound.
X-ref: #334 #340