-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tumbleweed wallpaper refresh #160
Conversation
Here's the transition from light to dark variant and show of matching overlap as advised by @hellcp |
I'm thinking if we really have to generate all individual resolutions or just the largest one and scale down (gnome has background scale properties etc). Also based on checking https://help.gnome.org/admin/system-admin-guide/stable/backgrounds-extra.html.en it seems that our xml si bit dated (backgrounds vs walllpaper). Do we want automatic transition or rather keep uri/dark-uri options (without time-based change). If we'd go for time-based change then we can't have the distribution one as default, as that would kill openQA. There I'd advise project. But I think sticking with light/dark works. |
Why would we do time based change? Let's change them based on light or dark theme. openQA to my knowledge doesn't test dark theme, so it wouldn't make any difference to it, since it would only ever see the light theme wallpaper. Also I get the feeling that project wallpaper would fit better in the wallpapers repository since it's presumably also going to be shared between Leap and Tumbleweed |
Fully agreed about dark/light theme @hellcp. The only problem with wallpapers is that it will very likely be just suggested. So we don't dramatically increase space on livecds etc. And then the project one would not make it to many systems. I'm fine with the digital-art/geo wallpaper + photo be in a suggested walllpaper but I really wanted to hhave these two (three if we count dark/light separately) on each system. |
Good catch @hellcp |
Must be a github glitch where they display rendered png vs svg. I think we should investigate why the png is so much lighter. here's png export 16:9 vs 16:10 Here are svgs in inkscape |
1a62cce
to
a5ef5e7
Compare
Let me make a test build to avoid any issues in makefile etc ... |
a5ef5e7
to
9faf5f7
Compare
Make passed, ready to get merged!
|
a2e3878
to
d473f55
Compare
* Graphics from @hellcp. Many thanks for all the work! * Resolves TW part of gh#openSUSE#135 * Covers both dark and light variant * Use single 4096x4096 file as mentioned in gh#openSUSE#161 * Use the dark 800x600 also for the back.png * Use default.png instead of default-light.png to maximize compatability.
d473f55
to
3b24ec6
Compare
@@ -5,7 +5,7 @@ THEME=openSUSE | |||
all: info openSUSE.d | |||
|
|||
info: | |||
echo "Make sure to have rsvg-view and GraphicsMagick installed" | |||
echo "Make sure to have rsvg-view, GraphicsMagick and optipng installed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync with Leap 16.0, we do use optipng
@@ -67,25 +67,26 @@ libreoffice.d: | |||
mkdir -p openSUSE/libreoffice/program | |||
cp -r libreoffice/flat_logo.svg libreoffice/sofficerc libreoffice/shell openSUSE/libreoffice/program/ | |||
rsvg-convert libreoffice/intro.svg -o openSUSE/libreoffice/program/intro.png | |||
optipng -o7 openSUSE/libreoffice/program/intro.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync with Leap 16.0 we are using optipng there too
<filename-dark>/usr/share/wallpapers/openSUSEdefault/contents/images/default-dark.png</filename-dark> | ||
<options>zoom</options> | ||
<shade_type>solid</shade_type> | ||
<pcolor>#63bbb2ff</pcolor> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used Tumbleweed light bg color as primary, dark bg as secondary
Shared with Marketing channel, no feedback in PR, seems like people are okay with it. Merging! |
* New Tumbleweed logo gh#openSUSE/branding#160 * New Leap logo gh#openSUSE/branding#154
* Add openSUSE Slowroll * Updated logos for openSUSE Leap and Tumbleweed gh#openSUSE/branding#154 gh#openSUSE/branding#160 * Update neofetch accordingly to gh#openSUSE/neofetch fork
Unified 4096x4096 TW wallpaper for Tumbleweed