-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize spec #25
Merged
Merged
Modernize spec #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just merged #24, so now there is a conflict. Could you rebase to current master? |
- Group tag is no longer required - BuildRoot need no longer be set - %defattr is no longer required
spec-cleaner moves defines above `Name:` and thereby adds needles noise to the diff
dcermak
force-pushed
the
modernize_spec
branch
from
November 17, 2020 15:19
cfef5a2
to
9c225c1
Compare
Tina Müller (tinita) <[email protected]> writes:
I just merged #24, so now there is a conflict. Could you rebase to current master?
Done
|
@perlpunk humble reminder :) |
Sorry for the late reply. After checking on some details via Chat I activated the PR on the cronjob host. |
perlpunk
reviewed
Jan 20, 2025
END | ||
|
||
my $all_patch_args_same = 1; | ||
my $common_patch_args = undef; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to change this in #55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of small fixes:
%make_build
and%autosetup