Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize spec #25

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Modernize spec #25

merged 5 commits into from
Jan 7, 2021

Conversation

dcermak
Copy link
Contributor

@dcermak dcermak commented Nov 13, 2020

Collection of small fixes:

  • remove obsolete spec file entries like the group tag
  • switch to more modern macros like %make_build and %autosetup

@perlpunk
Copy link
Collaborator

I just merged #24, so now there is a conflict. Could you rebase to current master?

- Group tag is no longer required
- BuildRoot need no longer be set
- %defattr is no longer required
spec-cleaner moves defines above `Name:` and thereby adds needles noise to the diff
@dcermak
Copy link
Contributor Author

dcermak commented Nov 17, 2020 via email

@dcermak
Copy link
Contributor Author

dcermak commented Dec 2, 2020

@perlpunk humble reminder :)

@perlpunk
Copy link
Collaborator

Sorry for the late reply. After checking on some details via Chat I activated the PR on the cronjob host.

@perlpunk perlpunk merged commit e6526a8 into openSUSE:master Jan 7, 2021
END

my $all_patch_args_same = 1;
my $common_patch_args = undef;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to change this in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants