Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: fix RPM specfile groups, call ldconfig directly #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dist: fix RPM specfile groups, call ldconfig directly #330

wants to merge 1 commit into from

Conversation

jengelh
Copy link

@jengelh jengelh commented Aug 26, 2017

No description provided.

@@ -22,7 +22,7 @@ Version: @VERSION@
Release: 0
Summary: Library for storage management
License: GPL-2.0
Group: System/Libraries
Group: Development/Libraries/C and C++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? What are the definitions for those two groups?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System/Libraries: "Packages in this group should already be installed automatically because of a dependency." libstorage-ng.src.rpm (that is what line 25 touches here) however neither contains a .so file, nor does it get autoinstalled.
More group descriptions are on https://en.opensuse.org/openSUSE:Package_group_guidelines#System .

@wfeldt
Copy link
Member

wfeldt commented Sep 5, 2017

Note that libstorage-ng.spec.in is not used. See README.md.

@jengelh
Copy link
Author

jengelh commented Sep 5, 2017

@wfeldt Please get your team mechanics in order. It is maximally annoying to get redirected in circles. OBS says "go use github" and github people say "go use OBS".

The target project YaST:Head is not accepting requests because: 
The YaST packages are developed at Github (https://github.com/yast or https://github.com/libyui) and are automatically submitted to YaST:Head OBS project by Jenkins CI (http://ci.opensuse.org/view/Yast/) after each Git commit (if the testsuite passes).

See "CONTRIBUTING.md" file at the respective Github repository for more details.


@wfeldt
Copy link
Member

wfeldt commented Sep 5, 2017

@jengelh Sorry, wasn't aware of this. Will check.

@wfeldt
Copy link
Member

wfeldt commented Sep 5, 2017

Yes, indeed. And you can't override the project settings with per-package settings to turn it off easily for libstorage-ng.

@wfeldt
Copy link
Member

wfeldt commented Sep 5, 2017

@jengelh After discussion with @shundhammer: for the time being, continue patching spec.in. If anything is agreed on the patch will be manually added to obs. For the future, tooling will be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants