Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forward users to plasma-welcome if it is installed #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: forward users to plasma-welcome if it is installed #28

wants to merge 1 commit into from

Conversation

pontaoski
Copy link
Member

possibility

aleixpol
aleixpol reviewed Sep 20, 2022
View reviewed changes
Copy link

@aleixpol aleixpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend getting closer to Plasma 5.27 release which is when plasma-welcome should first be released to consider something like this.

src/launcher.cpp
#include "launcher.h"

Launcher::Launcher(QObject *parent) :
QObject(parent),
m_process(new QProcess(this))
{
m_plasmaWelcomeInstalled = programExists("plasma-welcome");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use QStandardPaths::findExecutable

@Pointedstick
Copy link

So the way we're planning to do this in Plasma is for Plasma itself to launch welcome-center on the first boot, so if you want to go in this direction, you'd need to patch out that part in Plasma, or we could provide a CMake flag for it I guess. Which we may end up doing anyway to accommodate distros that don't want to show it at all, but want it to be installed to keep the "show release notes after upgrade" functionality working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleixpol aleixpol aleixpol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pontaoski @Pointedstick @aleixpol