Issue openam#206 Add options for Cookie SameSite attribute #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsujiguchitky
force-pushed
the
issues/openam/206-cookie-samesite
branch
from
6419534
to
910dd9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis
Chrome treats cookies that have no declared SameSite value as SameSite=Lax cookies.
As a result, OpenAM has some troubles (See openam-jp/openam#206).
If XUI is enabled, OpenAM set cookies not only on the server side but also on the client side.
Therefore, this project also needs to be changed for SameSite.
Solution
Add a parameter to the method that creates the cookie.
Testing
Test with openam-jp/openam#207