Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for Wifi shield #119

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

robertoostenveld
Copy link

while reading through the code to find out how it deals with the (mostly undocumented) wifi shield, I have made some updated to the documentation.

@robertoostenveld robertoostenveld changed the title improvements to documentation for Wifi shield improvements for Wifi shield Apr 21, 2019
@robertoostenveld
Copy link
Author

Furthermore, testing the code with wifi+cyton I also made some small code changes. It now runs, but the time courses are not yet correct, i.e. all numbers are the same, and don't match the signals I can see with the same hardware in the OpenBCI GUI application.

@robertoostenveld robertoostenveld marked this pull request as ready for review April 21, 2019 14:15
@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #119 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #119      +/-   ##
=========================================
- Coverage   37.46%   37.3%   -0.17%     
=========================================
  Files           9       9              
  Lines        1588    1595       +7     
=========================================
  Hits          595     595              
- Misses        993    1000       +7
Impacted Files Coverage Δ
openbci/ganglion.py 13.86% <ø> (ø) ⬆️
openbci/cyton.py 47.13% <0%> (-0.38%) ⬇️
openbci/wifi.py 20.65% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2288eb...aadfcd7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants