Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose things #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 63 additions & 24 deletions dex/src/critbit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,35 @@ impl LeafNode {
}
}

pub struct LeafNodeIterator<'a> {
descending: bool,
slab: &'a Slab,
stack: Vec<NodeHandle>,
}

impl<'a> Iterator for LeafNodeIterator<'a> {
type Item = &'a LeafNode;

fn next(&mut self) -> Option<Self::Item> {
while let Some(node_handle) = self.stack.pop() {
let node_ref = self.slab.get(node_handle).unwrap().case().unwrap();
match node_ref {
NodeRef::Inner(inner) => {
if self.descending {
self.stack.push(inner.children[0]);
self.stack.push(inner.children[1]);
} else {
self.stack.push(inner.children[1]);
self.stack.push(inner.children[0]);
}
}
NodeRef::Leaf(leaf) => return Some(leaf),
}
}
None
}
}

#[derive(Copy, Clone)]
#[repr(packed)]
#[allow(dead_code)]
Expand Down Expand Up @@ -724,29 +753,16 @@ impl Slab {
self.remove_by_key(self.get(self.find_max()?)?.key()?)
}

#[cfg(test)]
fn traverse(&self) -> Vec<&LeafNode> {
fn walk_rec<'a>(slab: &'a Slab, sub_root: NodeHandle, buf: &mut Vec<&'a LeafNode>) {
match slab.get(sub_root).unwrap().case().unwrap() {
NodeRef::Leaf(leaf) => {
buf.push(leaf);
}
NodeRef::Inner(inner) => {
walk_rec(slab, inner.children[0], buf);
walk_rec(slab, inner.children[1], buf);
}
}
pub fn iter(&self, descending: bool) -> LeafNodeIterator<'_> {
let mut stack = vec![];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's worth initializing this one with a large enough capacity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the bump allocator in solana runtime makes dynamic vector resizing deceptively brutal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see anything in history giving an hint at what vec capacity we want to start with, any hint?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vec::with_capacity(self.header().leaf_count as usize);

if let Some(node_handle) = self.root() {
stack.push(node_handle);
}

let mut buf = Vec::with_capacity(self.header().leaf_count as usize);
if let Some(r) = self.root() {
walk_rec(self, r, &mut buf);
}
if buf.len() != buf.capacity() {
self.hexdump();
LeafNodeIterator {
descending,
slab: self,
stack,
}
assert_eq!(buf.len(), buf.capacity());
buf
}

#[cfg(test)]
Expand Down Expand Up @@ -825,11 +841,10 @@ mod tests {
use super::*;
use bytemuck::bytes_of;
use rand::prelude::*;
use std::collections::BTreeMap;

#[test]
fn simulate_find_min() {
use std::collections::BTreeMap;

for trial in 0..10u64 {
let mut aligned_buf = vec![0u64; 10_000];
let bytes: &mut [u8] = cast_slice_mut(aligned_buf.as_mut_slice());
Expand Down Expand Up @@ -931,7 +946,7 @@ mod tests {
for i in 0..100_000 {
slab.check_invariants();
let model_state = model.values().collect::<Vec<_>>();
let slab_state = slab.traverse();
let slab_state: Vec<&LeafNode> = slab.iter(false).collect();
assert_eq!(model_state, slab_state);

match weights[dist.sample(&mut rng)].0 {
Expand Down Expand Up @@ -995,4 +1010,28 @@ mod tests {
}
}
}

#[test]
fn test_leaf_node_iter() {
let mut aligned_buf = vec![0u64; 10_000];
let bytes: &mut [u8] = cast_slice_mut(aligned_buf.as_mut_slice());

let slab: &mut Slab = Slab::new(bytes);
let mut model: BTreeMap<u128, LeafNode> = BTreeMap::new();

let mut rng = StdRng::from_entropy();

for _i in 0..100 {
let offset = rng.gen();
let key = rng.gen();
let owner = rng.gen();
let qty = rng.gen();
let leaf = LeafNode::new(offset, key, owner, qty, FeeTier::Base, 0);

slab.insert_leaf(&leaf).unwrap();
model.insert(key, leaf).ok_or(()).unwrap_err();
}

assert!(slab.iter(false).eq(model.values()));
}
}
3 changes: 2 additions & 1 deletion dex/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ pub mod error;
mod tests;

pub mod critbit;
mod fees;
pub mod fees;
pub mod instruction;
pub mod matching;
pub mod state;
pub mod utils;

#[cfg(all(feature = "program", not(feature = "no-entrypoint")))]
use solana_program::entrypoint;
Expand Down
129 changes: 129 additions & 0 deletions dex/src/utils.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
use std::iter::Peekable;

use crate::{
critbit::{LeafNodeIterator, Slab},
matching::Side,
};

pub struct OrderBook<'a> {
side: Side,
slab: &'a Slab,
}

impl<'a> OrderBook<'a> {
pub fn new(side: Side, slab: &'a Slab) -> Self {
OrderBook { side, slab }
}

/// Iterate over level 2 data
pub fn levels(&'a self) -> LevelsIterator<'a> {
let is_descending = self.side == Side::Bid;
LevelsIterator {
leafs: self.slab.iter(is_descending).peekable(),
}
}
}
Copy link

@jarry-xiao jarry-xiao Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can do this in a single expression if you import itertools:

self
    .slab
    .iter(is_descending)
    .map(|leaf| (leaf.price(), leaf.quantity()))
    .group_by(|(p, q) *p)
    .map(|price, group| Level {price, quantity: group.map(|(_, q)| q).sum() })

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way i found that would satisfy lifetime requirements is to add an iter function on LevelsIterator, is this how we want it?

pub struct LevelsIterator<'a> {
    leafs: LeafNodeIterator<'a>,
}

impl<'a> LevelsIterator<'a> {
    fn iter(&'a self) -> Box<dyn Iterator<Item=Level> + 'a> {
        Box::new(self.leafs
            .map(|leaf| (leaf.price(), leaf.quantity()))
            .group_by(|(p, q)| *p)
            .into_iter()
            .map(|(price, group)| Level {
                price: price.get(),
                quantity: group.map(|(_, q)| q).sum(),
            }))
    }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor Author

@Arrowana Arrowana Dec 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up not adding this, i think while more elegant we end up bringing this heap allocation we didn't have before so any program using this will pay. Let me know if you think it is essential


/// Level 2 data
///
/// Values are in lot sizes.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct Level {
pub price: u64,
pub quantity: u64,
}

pub struct LevelsIterator<'a> {
leafs: Peekable<LeafNodeIterator<'a>>,
}

impl Iterator for LevelsIterator<'_> {
type Item = Level;

fn next(&mut self) -> Option<Self::Item> {
let mut level: Option<Level> = None;
while let Some(leaf) = self.leafs.peek() {
let price = leaf.price().get();
let quantity = leaf.quantity();
match &mut level {
Some(Level {
price: cur_price,
quantity: cur_quantity,
}) => {
if price == *cur_price {
*cur_quantity += quantity;
} else {
return level;
}
}
None => {
level = Some(Level { price, quantity });
}
}
self.leafs.next();
}
level
}
}

#[cfg(test)]
mod tests {
use super::*;
use crate::{critbit::LeafNode, fees::FeeTier};

use bytemuck::cast_slice_mut;
use rand::prelude::*;

#[test]
fn test_levels() {
let mut aligned_buf = vec![0u64; 10_000];
let bytes: &mut [u8] = cast_slice_mut(aligned_buf.as_mut_slice());
let slab = Slab::new(bytes);

let mut rng = StdRng::from_entropy();

let orders: Vec<(u64, u64)> = vec![
(1000, 50),
(1000, 25),
(1300, 100),
(1300, 40),
(1300, 250),
(1480, 36),
(1495, 3000),
(1495, 340),
];
for (i, (price, qty)) in orders.into_iter().enumerate() {
let offset = rng.gen();
let owner = rng.gen();
let key = ((price as u128) << 64) | (!(i as u64) as u128);

slab.insert_leaf(&LeafNode::new(offset, key, owner, qty, FeeTier::Base, 0))
.unwrap();
}

let ask_levels = vec![
Level {
price: 1000,
quantity: 75,
},
Level {
price: 1300,
quantity: 390,
},
Level {
price: 1480,
quantity: 36,
},
Level {
price: 1495,
quantity: 3340,
},
];

let orderbook_asks = OrderBook::new(Side::Ask, slab);
assert!(ask_levels.clone().into_iter().eq(orderbook_asks.levels()));

let orderbook_bids = OrderBook::new(Side::Bid, slab);
assert!(ask_levels.into_iter().rev().eq(orderbook_bids.levels()));
}
}