Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear modal notifs when opening modal #1051

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Clear modal notifs when opening modal #1051

wants to merge 6 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 10, 2025

When opening a modal, modal notifications were not properly cleared. This would lead to notifications being displayed in the wrong modals, i.e. "This event cannot be edited due to an active workflow" would appear on a create series modal. This patch should fix that.

Includes #1021.

How to test this

Can be tested as usual. Trigger a warning in one modal and check if it appears in different modals.

Arnei added 2 commits December 18, 2024 15:13
@Arnei
Fix notification display in event metadata tab
ae4fbd6 
Notifications were not being rendered in the
metadata tab of the event details, especially the
"Active Workflow"-notification. This patch fixes that.

This patch also fixes:
- The "Active Workflow"-notification being rendered
multiple times.
- The "Active Workflow"-notification being
rendered even when there is no active workflow
anymore.
@Arnei
Clear modal notifs when opening modal
21400dc 
When opening a modal, modal notifications were
not properly cleared. This would lead to notifications
being displayed in the wrong modals, i.e. "This
event cannot be edited due to an active workflow"
would appear on a create series modal.
This patch should fix that.
@Arnei Arnei added the type:bug Something isn't working label Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1051

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1051

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/1051/2025-01-23_15-57-22/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arnei