Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make header icons look the same when focused #1055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 14, 2025

Fixes #790.

Some of the icons in the header are cointained within anchor elements, making their border outline when focused look different from the icons cointained in buttons. This patch throws some css at the anchor elements to make them look the same as their button counterparts.

Before:
Bildschirmfoto vom 2025-01-14 09-20-48

After:
Bildschirmfoto vom 2025-01-14 09-21-00

How to test this

Can be tested as usual.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Some of the icons in the header are cointained
within anchor elements, making their border
outline when focused look different from the icons
cointained in buttons. This patch throws some
css at the anchor elements to make them look
the same as their button counterparts.
@Arnei Arnei added the type:visual-clarity Improves UI readability label Jan 14, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1055

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1055

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1055/2025-01-14_08-22-26/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon container size in header
1 participant