-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show conflicting scheduling events for new events #220
Show conflicting scheduling events for new events #220
Conversation
When trying to schedule a new event, there already is a notification if the new event would cause a conflict with an already scheduled event. However, it would not tell you with which event, leaving you guessing on how to resolve the conflict. This display the conflicting event, same as when trying to reschedule an event in the event details.
Testing this I saw:
|
Thanks for the review, will look into it. |
When scheduling a new event with a conflicting date, a notification will appear telling you about a "Planning conflict" (or something like that). This notification would never go away by itself, even if you selected a non- conflicting date. This fixes that.
If it happens across many different PRs, it is likely it's own issue? |
This pull request has conflicts ☹ |
|
||
{ | ||
/*list of scheduling conflicts*/ | ||
conflicts.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main conflict blob is appearing, but this doesn't ever get added to the DOM. Searching for scheduling-conflict
doesn't find any elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hot dang the future is amazing. You can't see my mouse, but here's a screencast. Same behaviour with Chrome. Tested via the proxy against a docker-based 15.2.
Screencast from 2024-02-29 14-09-23.webm
Also unclear why the X in the conflict blob (along with a bunch of other things like the OC logo, or the language flag) is missing, but it's normal on my machine at least :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, i dare say your normal is not expected behaviour. :D
Could it be that proxying to docker is somehow the problem? Seems to be main difference between our systems, and that proxy is a fickle thing.
This pull request has conflicts ☹ |
…nflicts-scheduling-new-event
This pull request has conflicts ☹ |
Fixes #132
When trying to schedule a new event, there already is a notification if the new event would cause a conflict with an already scheduled event. However, it would not tell you with which event, leaving you guessing on how to resolve the conflict. This display the conflicting event, same as when trying to reschedule an event in the event details.