Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show conflicting scheduling events for new events #220

Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Nov 3, 2023

Fixes #132

When trying to schedule a new event, there already is a notification if the new event would cause a conflict with an already scheduled event. However, it would not tell you with which event, leaving you guessing on how to resolve the conflict. This display the conflicting event, same as when trying to reschedule an event in the event details.

When trying to schedule a new event, there already is a notification
if the new event would cause a conflict with an already scheduled
event. However, it would not tell you with which event, leaving you
guessing on how to resolve the conflict. This display the conflicting
event, same as when trying to reschedule an event in the event
details.
@Arnei Arnei added the type:bug Something isn't working label Nov 3, 2023
@gregorydlogan
Copy link
Member

Testing this I saw:

  • False positive warnings where it said I had a conflict when I hadn't scheduled anything at all yet
  • The warning did not go away when the desired time changed
    • The false positive might be responsible for this too, manually closing the warning made it go away for a screen or two, but then it'd be back
  • Uncaught Runtime Errors about state mutations. I see this one a lot, across all reviews.

@Arnei
Copy link
Member Author

Arnei commented Jan 17, 2024

Thanks for the review, will look into it.

Arnei added 2 commits January 17, 2024 13:42
When scheduling a new event with a conflicting date,
a notification will appear telling you about a "Planning
conflict" (or something like that). This notification would
never go away by itself, even if you selected a non-
conflicting date. This fixes that.
@Arnei
Copy link
Member Author

Arnei commented Jan 17, 2024

Uncaught Runtime Errors about state mutations. I see this one a lot, across all reviews.

If it happens across many different PRs, it is likely it's own issue?

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.


{
/*list of scheduling conflicts*/
conflicts.length > 0 && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main conflict blob is appearing, but this doesn't ever get added to the DOM. Searching for scheduling-conflict doesn't find any elements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Works on my machine":
Bildschirmfoto vom 2024-02-29 14-55-32

Maybe you could share more details on how exactly you are testing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot dang the future is amazing. You can't see my mouse, but here's a screencast. Same behaviour with Chrome. Tested via the proxy against a docker-based 15.2.
Screencast from 2024-02-29 14-09-23.webm

Also unclear why the X in the conflict blob (along with a bunch of other things like the OC logo, or the language flag) is missing, but it's normal on my machine at least :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, i dare say your normal is not expected behaviour. :D

Could it be that proxying to docker is somehow the problem? Seems to be main difference between our systems, and that proxy is a fickle thing.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@gregorydlogan gregorydlogan self-assigned this May 24, 2024
@gregorydlogan gregorydlogan merged commit 97d8aa1 into opencast:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show user with which events they have a scheduling conflict
2 participants