fix regression in lib/payments sendEmailNotifications (#10069)

should. be triggered even if transaction is void
opencollective · Apr 27, 2024 · aa18000 · aa18000
1 parent 51aa739
commit aa18000
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/server/lib/payments.ts b/server/lib/payments.ts
@@ -614,7 +614,7 @@ export async function associateTransactionRefundId(
  * In all cases, transaction.type is CREDIT.
  *
  */
-export const sendEmailNotifications = (order: OrderModelInterface, transaction?: TransactionInterface): void => {
+export const sendEmailNotifications = (order: OrderModelInterface, transaction?: TransactionInterface | void): void => {
   debug('sendEmailNotifications');
   if (
     transaction &&
@@ -749,9 +749,7 @@ export const executeOrder = async (
     order.paymentMethod.save();
   }
 
-  if (transaction) {
-    sendEmailNotifications(order, transaction);
-  }
+  sendEmailNotifications(order, transaction);
 
   // Register gift card emitter as collective backer too
   if (transaction && transaction.UsingGiftCardFromCollectiveId) {