[Edgecore][as9516-32d] Access BMC by using libcurl #941

WillyLiu-EC · 2023-05-31T00:58:30Z

[Edgecore][as9516-32d] Access BMC by using libcurl

Modify kernel config
This modification is for creating usb0 interface.
And then, it can access BMC through usb0
Implement the BMC curl accessing for ONL
To make sure BMC response, it uses libcurl to access BMC.
Fix the issus that failed with build ONL
It can not build ONL for master. Need to modify the debian path for stretch.

paulmenzel

Thank you for your contribution.

Please fix the typos and formatting of the merge/pull request description. Please also describe the goal. Where is OpenBMCv1 installed on?

paulmenzel · 2023-05-31T11:58:03Z

builds/any/rootfs/stretch/standard/standard.yml

@@ -29,14 +29,14 @@ Multistrap:

  Debian:
    packages: *Packages
-    source: http://${DEBIAN_MIRROR}
+    source: http://archive.debian.org/debian/


This looks unrelated.

We git clone the codebase from community and build it. The building result is failed.
We reference the this modification to make sure the success building.
https://github.com/opencomputeproject/OpenNetworkLinux/pull/933/files

Although this modification actually is unrelated for as9516-32d platform, the ONL installer need to build successfully.

We can close this PR and send the two PR(one for building, one for as9516-32d) if need be.

We git clone the codebase from community and build it. The building result is failed.
We reference the this modification to make sure the success building. https://github.com/opencomputeproject/OpenNetworkLinux/pull/933/files

You should then merge that branch, so the relationship is clear.

We can close this PR and send the two PR(one for building, one for as9516-32d) if need be.

No need to close this one. Just “force-push” your amended commits.

We git clone the codebase from community and build it. The building result is failed.
We reference the this modification to make sure the success building. https://github.com/opencomputeproject/OpenNetworkLinux/pull/933/files

You should then merge that branch, so the relationship is clear.

We can close this PR and send the two PR(one for building, one for as9516-32d) if need be.

No need to close this one. Just “force-push” your amended commits.

This PR is related jessie and wheezy, not include stretch. And this PR provider is not us.
https://github.com/opencomputeproject/OpenNetworkLinux/pull/933/files

For the clear relationship, should we send a new PR for stretch ?
And then remove this stretch modification from this PR ?

WillyLiu-EC · 2023-06-01T06:08:47Z

Thank you for your contribution.

Please fix the typos and formatting of the merge/pull request description. Please also describe the goal. Where is OpenBMCv1 installed on?

Thank you for your suggestion.
About this question, maybe we modify the branch name as9516-32d_libcrul_with_openbmc_v1 to as9516-32d_libcrul_with_bmc.
The main modifications is using libcurl to access bmc.

paulmenzel · 2023-06-01T06:16:38Z

In my opinion the branch name is less important than the lost discussion/comments of the merge/pull request.

Should you change it, please spell curl correctly. ;-)

WillyLiu-EC · 2023-06-01T06:36:37Z

In my opinion the branch name is less important than the lost discussion/comments of the merge/pull request.

Should you change it, please spell curl correctly. ;-)

Sorry about wrong branch name.
The correct branch name: as9516-32d_libcurl_with_bmc

1. Modify kernel config for using usb0 interface 2. Implement the BMC curl accessing for ONL 3. Fix the issus that failed building with stretch Signed-off-by: Willy Liu <[email protected]>

WillyLiu-EC · 2023-06-01T07:47:01Z

In my opinion the branch name is less important than the lost discussion/comments of the merge/pull request.

Should you change it, please spell curl correctly. ;-)

OK, we already modify it.
please check it.

Best regards

paulmenzel · 2023-06-01T07:59:29Z

Thank you for the improvements. Still some requests:

Please split the commit into one commit per item you mentioned with a commit message. (Answering for example the question: „Why is the usb0 interface needed for BMC?“.)
Please do not indent the merge/pull request description with four spaces. Currently GitHub marks it up as a code block (monospace).

WillyLiu-EC · 2023-06-01T08:28:38Z

Thank you for the improvements. Still some requests:

Please split the commit into one commit per item you mentioned with a commit message. (Answering for example the question: „Why is the usb0 interface needed for BMC?“.)

Please do not indent the merge/pull request description with four spaces. Currently GitHub marks it up as a code block (monospace).

Thanks for your suggestion.
Please check it.

sonoble · 2023-09-01T20:53:46Z

Hi,
I am stepping through the outstanding PRs, this one does not compile when you run "make docker" due to an issue with curl.

make[4]: warning: -jN forced in submake: disabling jobserver mode. LinkingShared[release]: libonlp-platform-defaults-module::libonlp-platform-defaults.so /usr/lib/gcc-cross/aarch64-linux-gnu/6/../../../../aarch64-linux-gnu/bin/ld: cannot find -lcurl collect2: error: ld returned 1 exit status

WillyLiu-EC · 2023-09-11T08:27:49Z

Hi, I am stepping through the outstanding PRs, this one does not compile when you run "make docker" due to an issue with curl.

make[4]: warning: -jN forced in submake: disabling jobserver mode. LinkingShared[release]: libonlp-platform-defaults-module::libonlp-platform-defaults.so /usr/lib/gcc-cross/aarch64-linux-gnu/6/../../../../aarch64-linux-gnu/bin/ld: cannot find -lcurl collect2: error: ld returned 1 exit status

Hi
I download(git clone)a new codebase from this branch. And the the building result is successful.
Could you download(git clone) a new codebase to build again ?

Best regards,
WillyLiu

sonoble · 2023-09-11T19:05:54Z

Hi WillyLiu,

I downloaded the repo and patched but I get the same failure.. are you running "make docker" after you clone and patch?

WillyLiu-EC · 2023-09-12T01:49:14Z

Hi WillyLiu,

I downloaded the repo and patched but I get the same failure.. are you running "make docker" after you clone and patch?

Our building process

docker/tools/onlbuilder -9
source setup.env
make amd64

sonoble · 2023-09-12T02:53:59Z

Hello, So the issue is that we can't merge anything that breaks the general build, hence the "make docker" test which is the first way we check PRs.

…

On Mon, Sep 11, 2023, 6:49 PM WillyLiu-EC ***@***.***> wrote: Hi WillyLiu, I downloaded the repo and patched but I get the same failure.. are you running "make docker" after you clone and patch? Our building process 1. docker/tools/onlbuilder -9 2. source setup.env 3. make amd64 4. — Reply to this email directly, view it on GitHub <#941 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAP5WH443RX3X6BJ2VJBGYDXZ65SLANCNFSM6AAAAAAYUXPPTU> . You are receiving this because you commented.Message ID: ***@***.***>

WillyLiu-EC · 2024-03-22T02:19:01Z

New mail: [email protected]

paulmenzel suggested changes May 31, 2023

View reviewed changes

[Edgecore][as9516-32d] Access bmc by using libcurl

5993f24

1. Modify kernel config for using usb0 interface 2. Implement the BMC curl accessing for ONL 3. Fix the issus that failed building with stretch Signed-off-by: Willy Liu <[email protected]>

WillyLiu-EC force-pushed the as9516-32d_libcrul_with_openbmc_v1 branch from 95be6f8 to 5993f24 Compare June 1, 2023 07:30

WillyLiu-EC changed the title ~~As9516 32d libcrul with openbmc v1~~ [AS9516-32D] Access bmc by using libcurl Jun 1, 2023

WillyLiu-EC changed the title ~~[AS9516-32D] Access bmc by using libcurl~~ [AS9516-32D] Access BMC by using libcurl Jun 1, 2023

WillyLiu-EC changed the title ~~[AS9516-32D] Access BMC by using libcurl~~ [Edgecore][as9516-32d] Access BMC by using libcurl Jun 1, 2023

Merge branch 'master' into as9516-32d_libcrul_with_openbmc_v1

e6e50c7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Edgecore][as9516-32d] Access BMC by using libcurl #941

[Edgecore][as9516-32d] Access BMC by using libcurl #941

WillyLiu-EC commented May 31, 2023 •

edited

Loading

paulmenzel left a comment

paulmenzel May 31, 2023

WillyLiu-EC Jun 1, 2023

paulmenzel Jun 1, 2023

WillyLiu-EC Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

paulmenzel commented Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

paulmenzel commented Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

sonoble commented Sep 1, 2023

WillyLiu-EC commented Sep 11, 2023

sonoble commented Sep 11, 2023 •

edited

Loading

WillyLiu-EC commented Sep 12, 2023

sonoble commented Sep 12, 2023 via email

WillyLiu-EC commented Mar 22, 2024

[Edgecore][as9516-32d] Access BMC by using libcurl #941

Are you sure you want to change the base?

[Edgecore][as9516-32d] Access BMC by using libcurl #941

Conversation

WillyLiu-EC commented May 31, 2023 • edited Loading

paulmenzel left a comment

Choose a reason for hiding this comment

paulmenzel May 31, 2023

Choose a reason for hiding this comment

WillyLiu-EC Jun 1, 2023

Choose a reason for hiding this comment

paulmenzel Jun 1, 2023

Choose a reason for hiding this comment

WillyLiu-EC Jun 1, 2023

Choose a reason for hiding this comment

WillyLiu-EC commented Jun 1, 2023

paulmenzel commented Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

paulmenzel commented Jun 1, 2023

WillyLiu-EC commented Jun 1, 2023

sonoble commented Sep 1, 2023

WillyLiu-EC commented Sep 11, 2023

sonoble commented Sep 11, 2023 • edited Loading

WillyLiu-EC commented Sep 12, 2023

sonoble commented Sep 12, 2023 via email

WillyLiu-EC commented Mar 22, 2024

WillyLiu-EC commented May 31, 2023 •

edited

Loading

sonoble commented Sep 11, 2023 •

edited

Loading