Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLS DS4101 platform #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicwu-cel
Copy link
Contributor

@nicwu-cel nicwu-cel commented Aug 6, 2024

  • Why I did it
    Add CLS DS4101 platform

CPU: Xeon-D 4Core CPU D1627/Xeon-D 8Core CPU D1649N
RAM: 2x 16GB DDR4/16GB DDR4
SSD: 64GB/128GB/256GB M.2 SSD
Switch ASIC: TH4-100G Switch IC, BCM56996
Ethernet Port: 800G OSFP port x 32 and 10G SFP+ x 2
PHY: Intel I210
PSU: 2x AC PSU 2000W, hotswappable
Cooling: 6+1 fan-tray modules, hotswappable
Airflow: F2B airflow
BMC: W/
Dimension: 438.5mm(W)x43.1mm(H)x657.5mm(D)
Linux kernel version: 5.4.40

Signed-off-by: Nicholas Wu <[email protected]>
@nicwu-cel
Copy link
Contributor Author

@paulmenzel

I would appreciate it if you could help review this pull request.

Looking forward to hearing from you soon.

Best Regards!

Copy link

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for adding support for the device. Please note, that Open Network Linux is currently unmaintained, and not quality assurance is happening. Contributions are only build-tested, and often merged without thorough review. I advise against offering such a system to customers.

For your contribution, it’d be great if you could split the one commit into logical commits, and also write commit messages so reviewers without access to the device or documentation know what is done.

@@ -85,3 +85,4 @@
- htop
- tree
- memtester
- ipmitool

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a separate commit.

Copy link

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please note, Open Network Linux is currently unmaintained as no vendor stepped up to provide resources for maintenance. That means, the versions are outdated and no quality assurance is done. Most contributions are only build-tested and accepted without thorough review. I advise against using ONL in this state in production.

For your contribution, please split the commit into smaller ones with an elaborate commit message so reviewers without access to the device or any documentation are able to review it. Noting what ASIC firmware was used and what tests were done would also be great.

@paulmenzel
Copy link

(Sorry for the double post, the USB network device in my Dell DA300 adapter dropped the connection, and I thought my first comment wasn’t submitted.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants