Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RIF attribute to specify if the corresponding My MAC entry should not be created.. #2021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erohsik
Copy link
Contributor

@erohsik erohsik commented May 29, 2024

Add an attribute used to specify if My MAC entry need not be created for this {port, vlan, MAC address}.

@erohsik erohsik changed the title Add a RIF attribute to specify if the correspodnig My MAC entry should not be created.. Add a RIF attribute to specify if the corresponding My MAC entry should not be created.. May 29, 2024
@erohsik
Copy link
Contributor Author

erohsik commented Jul 2, 2024

@itaibaz
I believe you had commented during the call.. Does this sound reasonable?

/**
 * @brief Attribute used to specify external My MAC entry that will
 * be used in place of any implicit entry created during RIF processing
 * for this {port, vlan, MAC address}
 *
 * @type sai_object_id_t
 * @flags CREATE_ONLY
 * @objects SAI_OBJECT_TYPE_MY_MAC
 * @allownull true
 * @default SAI_NULL_OBJECT_ID
 */
SAI_ROUTER_INTERFACE_ATTR_MY_MAC,

@itaibaz
Copy link
Collaborator

itaibaz commented Jul 2, 2024

Hi, the comment must have been from someone else, not me

@rlhui rlhui added the reviewed PR is discussed in SAI Meeting label Sep 19, 2024
@tjchadaga tjchadaga requested a review from kcudnik October 4, 2024 22:39
@tjchadaga
Copy link
Collaborator

@itaibaz, @rck-innovium, @JaiOCP - could you please help review?

@tjchadaga
Copy link
Collaborator

@erohsik - please help resolve conflicts on the branch

    be used in place of any implicit entry created during RIF processing

Signed-off-by: Kishore Gummadidala <[email protected]>
@erohsik
Copy link
Contributor Author

erohsik commented Nov 7, 2024

@erohsik - please help resolve conflicts on the branch

Done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR is discussed in SAI Meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants