Adding support to get a list of all reachable switch-id's from a fabr… #2047
Conversation
|
@kcudnik Hi , Kamil can you please review this commit , i will close the previous pull request . |
|
@harjotsinghpawra - do you want a slot to discuss this PR with the community? |
…ic port Signed-off-by: Harjot Singh <[email protected]>
harjotsinghpawra
force-pushed
the
reachability_v2
branch
from
18136be
to
9b02b6e
Compare
Signed-off-by: Harjot Singh <[email protected]>
harjotsinghpawra
force-pushed
the
reachability_v2
branch
from
9b02b6e
to
7c25ccd
Compare
|
@harjotsinghpawra Can you please more detail on this ? Can we discuss this in next weekly on Wednesday ? |
|
Hi Vineet,
Yes, I will be joining the weekly discussion but it's on Thursday right ?
Thanks and Regards
Harjot Singh
…On Thu, Sep 19, 2024 at 11:25 AM Vineet Mittal ***@***.***> wrote:
@harjotsinghpawra <https://github.com/harjotsinghpawra> Can you please
more detail on this ? Can we discuss this in next weekly on Wednesday ?
—
Reply to this email directly, view it on GitHub
<#2047 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJCT2Q252MU3IUB4AZ74JQ3ZXMJLFAVCNFSM6AAAAABKVXPIHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRRHA4DKMBXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
| /** | ||
| * @brief List of switch id's of all remote reachable switches | ||
| * | ||
| * @type sai_u16_list_t |
There was a problem hiding this comment.
I see data-type of switch-id as "sai_uint32_t". Should it be sai_u32_list_t ?
|
@harjotsinghpawra i do see SAI attribute SAI_PORT_ATTR_FABRIC_REACHABILITY is available to give us information about whether a fabric port is reachable from a switch id or not. I am still not sure how is this feature helping us since we already have all this information today. Also, reachability is point to point. A fabric port on a device can only be connected to one other remote port and not to multiple switch ids. Please share if i am missing anything, Here is the o/p from sonic device -
|
|
@harjotsinghpawra - could you please resolve branch conflicts and address comments on this PR? |
|
please resolve conflicts |
Adding support to get a list of all reachable switch-id's from a fabric port, currently we can only check from switch-id if its reachable or not .
SAI_PORT_ATTR_FABRIC_REACHABILITY_LIST