Developer NVIDIA (Improving on Failure Reason and logic of Force Update and some testcases) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsanac-nv
force-pushed
the
developer_nvidia
branch
from
0eed0dc
to
cbc8133
Compare
afsanac-nv
force-pushed
the
developer_nvidia
branch
from
638a6ca
to
851ebe7
Compare
…ailure Reason. Added a check in F8 testcase Signed-off-by: dhruvr <[email protected]>
afsanac-nv
force-pushed
the
developer_nvidia
branch
from
851ebe7
to
6734993
Compare
Signed-off-by: Dhruv Rathi <[email protected]>
| @@ -444,7 +454,7 @@ def RedFishFWUpdate(self, BinPath, URI, targets=[], is_multipart=False): | |||
| headers = {"Content-Type": "multipart/form-data"} | |||
| body = { | |||
| "UpdateFile": (BinPath, open(BinPath, "rb"), "application/octet-stream"), | |||
| "UpdateParameters" : ("Targets", json.dumps({"Targets": targets, "ForceUpdate": True if self.dut().multipart_force_update else False}),'application/json') | |||
| "UpdateParameters" : ("Targets", json.dumps({"Targets": targets, "ForceUpdate": True if is_force_update else False}),'application/json') | |||
There was a problem hiding this comment.
Are we saying that downgrade requires a ForceUpdate? Then we should this ask this as a standard?
There was a problem hiding this comment.
Yes for Multipart Update we need ForceUpdate for downgrade. We have the ForceUpdate under UpdateParameters in the redfish schema: https://redfish.dmtf.org/schemas/v1/UpdateService.v1_14_1.json
For update using HttpPushUri, ForceUpdate is not needed.
|
We are almost done reviewing this PR. Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Tests:
Sanity/Regression tests were run.