Add support for NH diff; refactor return type. #1090
robshakirgo.yml
on: pull_request
go
/
Static Analysis
10m 3s
go
/
staticcheck
6m 52s
Matrix: go / Build and Test
Annotations
10 errors
|
go / Static Analysis:
constants/const.go#L15
package comment should be of the form "Package constants ..."
|
|
go / Static Analysis:
server/server.go#L138
type name will be used as server.ServerOpt by other packages, and that stutters; consider calling this Opt
|
|
go / Static Analysis:
server/server.go#L167
comment on exported function WithRIBResolvedEntryHook should be of the form "WithRIBResolvedEntryHook ..."
|
|
go / Static Analysis:
server/server.go#L144
exported func WithPostChangeRIBHook returns unexported type *server.postChangeRibHook, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L169
exported func WithRIBResolvedEntryHook returns unexported type *server.resolvedEntryHook, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L196
exported func DisableRIBCheckFn returns unexported type *server.disableCheckFn, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L218
exported func WithVRFs returns unexported type *server.withVRFs, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L412
parameter 'ctx' seems to be unused, consider removing or renaming it as _
|
|
go / Static Analysis:
fluent/fluent.go#L307
exported const AllAFTs should have comment (or a comment on this block) or be unexported
|
|
go / Static Analysis:
fluent/fluent.go#L975
comment on exported const UnsupportedParameters should be of the form "UnsupportedParameters ..."
|