Skip to content

Add IsEmpty functions for Ops and ReconcileOps. #1120

Add IsEmpty functions for Ops and ReconcileOps.

Add IsEmpty functions for Ops and ReconcileOps. #1120

Triggered via pull request November 3, 2023 16:46
@robshakirrobshakir
synchronize #204
ops-isempty
Status Success
Total duration 10m 42s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

go.yml

on: pull_request
Matrix: go / Build and Test
Fit to window
Zoom out
Zoom in

Annotations

10 errors
go / Static Analysis: constants/const.go#L15
package comment should be of the form "Package constants ..."
go / Static Analysis: server/server.go#L144
exported func WithPostChangeRIBHook returns unexported type *server.postChangeRibHook, which can be annoying to use
go / Static Analysis: server/server.go#L169
exported func WithRIBResolvedEntryHook returns unexported type *server.resolvedEntryHook, which can be annoying to use
go / Static Analysis: server/server.go#L196
exported func DisableRIBCheckFn returns unexported type *server.disableCheckFn, which can be annoying to use
go / Static Analysis: server/server.go#L218
exported func WithVRFs returns unexported type *server.withVRFs, which can be annoying to use
go / Static Analysis: server/server.go#L138
type name will be used as server.ServerOpt by other packages, and that stutters; consider calling this Opt
go / Static Analysis: server/server.go#L167
comment on exported function WithRIBResolvedEntryHook should be of the form "WithRIBResolvedEntryHook ..."
go / Static Analysis: server/server.go#L412
parameter 'ctx' seems to be unused, consider removing or renaming it as _
go / Static Analysis: rib/helpers.go#L83
exported func NewFake returns unexported type *rib.fakeRIB, which can be annoying to use
go / Static Analysis: rib/helpers.go#L29
parameter 'opt' seems to be unused, consider removing or renaming it as _