Optimize output #190
Open
Optimize output #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <[email protected]>
jonboulle
reviewed
Oct 18, 2017
| @@ -72,7 +72,12 @@ func createHandle(context *cli.Context) error { | |||
|
|
|||
| } | |||
|
|
|||
| return err | |||
| if err != nil { | |||
| return fmt.Errorf("Creating failed: %v", err) | |||
There was a problem hiding this comment.
should probably use pkg/errors
| return fmt.Errorf("Creating failed: %v", err) | ||
| } | ||
|
|
||
| fmt.Println("Creating succeeded") |
There was a problem hiding this comment.
if you really want this output, it should go to stderr, not stdout
|
LGTM |
|
What is the purpose of this change? What do you mean by "Optimize Output"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao [email protected]