Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to override parquet_prefix and include idle costs #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

burahimu
Copy link

Hello there 👋🏼

This PR introduces several enhancements. The main changes are:

  • Allow to override the full parquet prefix. We wanted to add a by hour partitioning
  • Retrieve idle costs in order to know what we're wasting (we're not sure if the Glue table can handle idle costs)

Note

This PR is in draft until we confirm the latest point.

Copy link
Member

@lmello lmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution.
left some comments on it.

src/opencost_parquet_exporter.py Show resolved Hide resolved
src/opencost_parquet_exporter.py Show resolved Hide resolved
src/opencost_parquet_exporter.py Outdated Show resolved Hide resolved
src/opencost_parquet_exporter.py Outdated Show resolved Hide resolved
src/test_opencost_parquet_exporter.py Outdated Show resolved Hide resolved
src/test_opencost_parquet_exporter.py Show resolved Hide resolved
@burahimu burahimu marked this pull request as ready for review July 3, 2024 12:40
@lmello
Copy link
Member

lmello commented Sep 7, 2024

@burahimu We just merged a PR that implemented support for azure and removed the config from the code to external files to allow parametrization.

Can you have a look at the new code in v0.2.0-rc3 (which is in the main branch) and rebase your pr.

Thank you.

Signed-off-by: Brahim Boukoufallah <[email protected]>
@burahimu
Copy link
Author

@burahimu We just merged a PR that implemented support for azure and removed the config from the code to external files to allow parametrization.

Can you have a look at the new code in v0.2.0-rc3 (which is in the main branch) and rebase your pr.

Thank you.

Hi @lmello , it's rebased 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants