tests: Add Github Actions tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See here for more details: yaml/pyyaml#724 We should revert to 5.4 as soon as possible.
bellisk
force-pushed
the
tests/switch-to-github-actions-tests
branch
from
c4303f8
to
c6f9d54
Compare
Because I can't get them to work locally.
This is not needed since we now use the one from ckanext-switzerland-ng.
sarusarah
reviewed
Sep 26, 2023
| @@ -173,7 +173,7 @@ def xpath_get_rights_dict_form_rights_node(node): | |||
| if value_locale: | |||
| rights_dict[locale.lower()] = _clean_string(value_locale[0]) | |||
| return rights_dict | |||
| except: | |||
| except Exception: | |||
There was a problem hiding this comment.
Does it make sense to log the exception?
There was a problem hiding this comment.
To be honest, I'm not sure what kind of exception we could possibly be getting here. :-/ I don't think it's worth logging it, though, because when we use this rights dictionary, we actually only need it to have a valid rights name in one of the languages to get the correct rights id. (Here: https://github.com/opendata-swiss/ckanext-geocat/blob/master/ckanext/geocat/utils/csw_mapping.py#L399.)
sarusarah
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.