-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add Github Actions tests #120
Conversation
See here for more details: yaml/pyyaml#724 We should revert to 5.4 as soon as possible.
c4303f8
to
c6f9d54
Compare
Because I can't get them to work locally.
This is not needed since we now use the one from ckanext-switzerland-ng.
@@ -173,7 +173,7 @@ def xpath_get_rights_dict_form_rights_node(node): | |||
if value_locale: | |||
rights_dict[locale.lower()] = _clean_string(value_locale[0]) | |||
return rights_dict | |||
except: | |||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to log the exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not sure what kind of exception we could possibly be getting here. :-/ I don't think it's worth logging it, though, because when we use this rights dictionary, we actually only need it to have a valid rights name in one of the languages to get the correct rights id. (Here: https://github.com/opendata-swiss/ckanext-geocat/blob/master/ckanext/geocat/utils/csw_mapping.py#L399.)
No description provided.