Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt dcat page #272

Merged
merged 14 commits into from
Dec 19, 2023
Merged

Adapt dcat page #272

merged 14 commits into from
Dec 19, 2023

Conversation

mispichtig
Copy link
Collaborator

No description provided.

Copy link
Contributor

@kovalch kovalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, very nice.

I guess what is missing is temporalResolution for the resources.

would be also nice to agree on the prefixes abbreviations.
But I would leave it for now

- rdfs:seeAlso
- optional
- :fa:`exclamation` optional, **mandatory** for federal level, the legal basis must be indicated here
* - :fa:`exclamation` :ref:`qualifiedRelation <dcat-dataset-qualified-relation>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qualifiedRelation (in the ref) -> qualified relation

- :fa:`exclamation` optional, **mandatory** for federal level, the legal basis must be indicated here
* - :fa:`exclamation` :ref:`qualifiedRelation <dcat-dataset-qualified-relation>`
- dcat:qualifiedRelation
- optional :fa:`exclamation` replaces the property rdfs:seeAlso
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional -> optional,

@@ -577,6 +586,16 @@ dcat:theme (DCAT)

.. include:: dcat-examples/dataset-theme-rdf.rst

.. toggle-header::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use correct links in the dcat-examples/dataset-theme-ttl.rst (above)

.. toggle-header::
:header: Property ``foaf:page`` of ``dcat:Dataset`` in Turtle

.. include:: dcat-examples/dataset-documentation-ttl.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use this for the ttl (but remove spaces I put to make "<" visible):

< https://bag/covid-19 > a dcat:Dataset ;
foaf:Document < https://www.covid19.admin.ch/api/data/documentation > ,
< https://de.wikipedia.org/wiki/Datenmanagement > .

@@ -0,0 +1,13 @@
.. code-block:: Turtle
:caption: A ``dcat:Dataset`` with a ``rdfs:seeAlso`` in Turtle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move rdfs:seeAlso to
dcat:qualifiedRelation

@prefix foaf: <http://xmlns.com/foaf/0.1/> .

<https://bag/covid-19> a dcat:Distribution ;
foaf:Document [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<dcat:accessURL rdf:resource="http://stratigraphy.org/ICSchart/ChronostratChart2017-02.jpg"/>
<dct:format rdf:resource="https://www.iana.org/assignments/media-types/img/jpeg"/>
<dcat:Distribution rdf:about=""https://data.tg.ch/api/v2/catalog/datasets/sk-stat-47/exports/csv"">
<dcat:accessURL rdf:resource=""https://data.tg.ch/api/v2/catalog/datasets/sk-stat-47/exports/csv""/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you write accessURL information here?
could we remove it?

a dcat:Distribution ;
dcat:accessURL <http://stratigraphy.org/ICSchart/ChronostratChart2017-02.jpg> ;
dct:format <https://www.iana.org/assignments/media-types/img/jpeg> .
dcat:accessURL <https://data.tg.ch/api/v2/catalog/datasets/sk-stat-47/exports/csv> ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here, why do we add accessURL to this example?

xmlns:dct="http://purl.org/dc/terms/">

<dcat:Distribution rdf:about="http://stratigraphy.org/ICSchart/ChronostratChart2017-02.jpg">
<dcat:accessURL rdf:resource="http://stratigraphy.org/ICSchart/ChronostratChart2017-02.jpg"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here, why do we add accessURL to this example?


<http://stratigraphy.org/ICSchart/ChronostratChart2017-02.jpg>
a dcat:Distribution ;
dcat:accessURL <http://stratigraphy.org/ICSchart/ChronostratChart2017-02.jpg> ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here, why do we add accessURL to this example?

@mispichtig mispichtig merged commit 5333307 into master Dec 19, 2023
1 of 2 checks passed
@mispichtig mispichtig deleted the adapt-dcat-page branch December 19, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants