Enable mcad_ray_test

opendatahub-io · Oct 24, 2023 · bcaa0e8 · bcaa0e8
1 parent 8b8563e
commit bcaa0e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/tests/integration/mcad_ray_test.go b/tests/integration/mcad_ray_test.go
@@ -34,8 +34,6 @@ import (
 func TestMCADRay(t *testing.T) {
 	test := cfosupport.With(t)
 
-	test.T().Skip("Requires https://github.com/project-codeflare/codeflare-sdk/issues/190")
-
 	// Create a namespace
 	namespace := test.NewTestNamespace()
 
@@ -89,7 +87,7 @@ func TestMCADRay(t *testing.T) {
 		Should(
 			And(
 				HaveLen(1),
-				ContainElement(WithTransform(cfosupport.AppWrapperName, HavePrefix("mnistjob"))),
+				ContainElement(WithTransform(cfosupport.AppWrapperName, HavePrefix("mnisttest"))),
 				ContainElement(WithTransform(cfosupport.AppWrapperState, Equal(mcadv1beta1.AppWrapperStateActive))),
 			),
 		)

diff --git a/tests/integration/resources/mnist_ray_mini.ipynb b/tests/integration/resources/mnist_ray_mini.ipynb
@@ -40,7 +40,7 @@
    "outputs": [],
    "source": [
     "# Create our cluster and submit appwrapper\n",
-    "cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
+    "cluster = Cluster(ClusterConfiguration(namespace=namespace, name='mnisttest', head_cpus=2, head_memory=8, num_workers=1, min_cpus=1, max_cpus=1, min_memory=4, max_memory=4, num_gpus=0, instascale=False))"
    ]
   },
   {
@@ -53,18 +53,7 @@
    "outputs": [],
    "source": [
     "# Bring up the cluster\n",
-    "cluster.up()"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "a99d5aff",
-   "metadata": {
-    "tags": []
-   },
-   "outputs": [],
-   "source": [
+    "cluster.up()\n",
     "cluster.wait_ready()"
    ]
   },
@@ -99,7 +88,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "job = DDPJobDefinition(name=\"mnisttest\", script=\"mnist.py\", workspace=\"file:///opt/app-root/notebooks/..data\", scheduler_args={\"requirements\": \"/opt/app-root/notebooks/requirements.txt\"}).submit(cluster)"
+    "job = DDPJobDefinition(name=\"mnisttest\", script=\"mnist.py\", workspace=\"file:///opt/app-root/notebooks-ray/..data\", scheduler_args={\"requirements\": \"/opt/app-root/notebooks-ray/requirements.txt\"}).submit(cluster)"
    ]
   },
   {