Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash e2e tests #140

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Remove bash e2e tests #140

merged 1 commit into from
Oct 11, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Oct 11, 2023

Remove bash e2e tests as they are not needed any more.

Description

Bash tests were used in https://github.com/opendatahub-io/odh-manifests for manifest testing. As ODH switched from central manifest storage into using manifests directly from component repositories, these tests are not needed any more as they were replaced by Go tests.

How Has This Been Tested?

N/A

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 576c53e into opendatahub-io:main Oct 11, 2023
1 check passed
@sutaakar sutaakar deleted the bash branch October 11, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants