Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

periodic sync upstream KF to midstream ODH #134

Merged

Conversation

lucferbux and others added 11 commits October 8, 2024 12:09
Signed-off-by: Jenny <[email protected]>

fix tests

Signed-off-by: Jenny <[email protected]>

add fieldset to custom components

fix spacing issue with helper text

Signed-off-by: Jenny <[email protected]>

remove comment

Signed-off-by: Jenny <[email protected]>

fixes for text area

Signed-off-by: Jenny <[email protected]>

format

Signed-off-by: Jenny <[email protected]>

add model description fix

Signed-off-by: Jenny <[email protected]>

create reusable fieldset component

Signed-off-by: Jenny <[email protected]>

move fieldset to components

Signed-off-by: Jenny <[email protected]>

add prop for className

Signed-off-by: Jenny <[email protected]>

lint

Signed-off-by: Jenny <[email protected]>

fix import warnings

fix TS error with FormFieldset.tsx

Signed-off-by: Jenny <[email protected]>

fix import order errors
Signed-off-by: Jenny <[email protected]>

apply theming to model info screens

fix button color on hover

add comment

fix button color on hover

Signed-off-by: Jenny <[email protected]>

format

update to absolute path
…rontend (kubeflow#472)

Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.6.2 to 5.6.3.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.6.2...v5.6.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…i/frontend (kubeflow#475)

Bumps [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material) from 6.1.2 to 6.1.3.
- [Release notes](https://github.com/mui/material-ui/releases)
- [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/material-ui/commits/v6.1.3/packages/mui-material)

---
updated-dependencies:
- dependency-name: "@mui/material"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matteo Mortari <[email protected]>
Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 15, 2024

@tarilabs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-mro-optional 3c040ae link false /test e2e-odh-mro-optional
ci/prow/e2e-odh-model-registry-python-client 3c040ae link false /test e2e-odh-model-registry-python-client

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

the action is not needed in midstream
plan is to merge everything into one ODH dashboard image for midstream

Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs
Copy link
Member Author

clarified with dashboard team offline
implemented with d574a27

@tarilabs tarilabs added the lgtm label Oct 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 37c6570 into opendatahub-io:main Oct 16, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants