Skip to content

Commit

Permalink
Remove extraneous developer debugging code (#3376)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeff-phillips-18 authored Oct 25, 2024
1 parent d9788f8 commit 24cb2f7
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 16 deletions.
4 changes: 2 additions & 2 deletions frontend/src/components/MultiSelection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ export const MultiSelection: React.FC<MultiSelectionProps> = ({
</SelectList>
) : null}
{selectGroups.map((g, index) => (
<>
<React.Fragment key={g.id}>
<SelectGroup label={g.name} key={g.id}>
<SelectList isAriaMultiselectable>
{g.values.map((option) => (
Expand All @@ -352,7 +352,7 @@ export const MultiSelection: React.FC<MultiSelectionProps> = ({
</SelectList>
</SelectGroup>
{index < selectGroups.length - 1 || selectOptions.length ? <Divider /> : null}
</>
</React.Fragment>
))}
{selectOptions.length ||
(createOption && (!isCreateOptionOnTop || groupOptions.length === 0)) ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ const BiasMetricConfigSelector: React.FC<BiasMetricConfigSelectorProps> = ({
initialSelections,
}) => {
const { biasMetricConfigs, statusState } = useModelBiasData();
const [uiSelections, setUISelections] = React.useState<string>();
const [currentSelections, setCurrentSelections] = React.useState<string>();
const elementId = React.useId();

const spdConfigs = biasMetricConfigs.filter((x) => x.metricType === BiasMetricType.SPD);
Expand All @@ -26,10 +24,6 @@ const BiasMetricConfigSelector: React.FC<BiasMetricConfigSelectorProps> = ({
<span id={elementId} hidden>
Select the metrics to display charts for
</span>
<div>ALL: {biasMetricConfigs.map((c) => c.name).join(', ')}</div>
<div>UI: {uiSelections}</div>
<div>current: {currentSelections}</div>
<div>initialSelections: {initialSelections.map((s) => s.name).join(', ')}</div>
<MultiSelection
ariaLabel="Select a metric"
groupedValues={[
Expand All @@ -53,12 +47,6 @@ const BiasMetricConfigSelector: React.FC<BiasMetricConfigSelectorProps> = ({
},
]}
setValue={(newState: SelectionOptions[]) => {
setUISelections(
newState
.filter((s) => s.selected)
.map((s) => s.name)
.join(', '),
);
const selections = newState.reduce<BiasMetricConfig[]>((acc, item) => {
if (item.selected) {
const selectedConfig = biasMetricConfigs.find((s) => s.id === item.id);
Expand All @@ -68,7 +56,6 @@ const BiasMetricConfigSelector: React.FC<BiasMetricConfigSelectorProps> = ({
}
return acc;
}, []);
setCurrentSelections(selections.map((s) => s.name).join(', '));
onChange(selections);
}}
selectionRequired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const ContainerSizeSelector: React.FC<ContainerSizeSelectorProps> = ({
}) => (
<FormGroup label="Container size" fieldId="container-size" data-testid="container-size-group">
<SimpleSelect
id="jeff"
popperProps={{ appendTo: getDashboardMainContainer() }}
isFullWidth
value={value.name}
Expand Down

0 comments on commit 24cb2f7

Please sign in to comment.