-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-6647] Fix to show all artifacts in pipeline topology view #2779
[RHOAIENG-6647] Fix to show all artifacts in pipeline topology view #2779
Conversation
6a75f1d
to
3cc6840
Compare
3cc6840
to
2b34210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in UI and walked through code updates with @jeff-phillips-18 this afternoon. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-6647
Description
Artifacts with the same name created by different tasks were being thrown out due to duplicate IDs. Update the generation of the artifact nodes to create a unique ID for the artifact based on its parent task's ID.
Update the version of @patternfly/react-topology to 5.4.0-prerelease.1 to pickup a fix for correct placement of spacer nodes.
How Has This Been Tested?
Verified locally that the artifact nodes show up correctly with the correct dependencies.
Added a test for
usePipelineTaskTopology
to verify the correct number of nodes are returned.Screen shots
Before
After
Request review criteria: