-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for model versions table and empty state #2782
Tests for model versions table and empty state #2782
Conversation
5c9e9bb
to
1319302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes, and also can you pls move Model version tests to another file?
1319302
to
fe803cc
Compare
frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Seems great, there's a bit of a refactor in model registry view in cypress that we'll need to perform
frontend/src/__tests__/cypress/cypress/e2e/modelRegistry/ModelRegistry.cy.ts
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests for https://issues.redhat.com/browse/RHOAIENG-2236
https://issues.redhat.com/browse/RHOAIENG-2237
https://issues.redhat.com/browse/RHOAIENG-2234
Description
app-page-title
along with tests for the same.How Has This Been Tested?
Run Cypress test -
ModelRegistry.cy.ts
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main