Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for model versions table and empty state #2782

Merged

Conversation

manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented May 7, 2024

Tests for https://issues.redhat.com/browse/RHOAIENG-2236
https://issues.redhat.com/browse/RHOAIENG-2237
https://issues.redhat.com/browse/RHOAIENG-2234

Description

  • Added e2e tests for model versions empty state and model versions table
  • Fixed Actions button from Split button to normal dropdown according to mocks
  • The chip key values now reflects owner instead of just keyword
  • Fixed the app-page-title along with tests for the same.

How Has This Been Tested?

Run Cypress test -ModelRegistry.cy.ts

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 7, 2024
Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes, and also can you pls move Model version tests to another file?

frontend/src/__mocks__/mockModelVersionList.ts Outdated Show resolved Hide resolved
frontend/src/__mocks__/mockModelVersion.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Seems great, there's a bit of a refactor in model registry view in cypress that we'll need to perform

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 93c0851 into opendatahub-io:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants