[RHOAIENG-2404] Replace remaining PF deprecated components #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/concepts/roleBinding/RoleBindingPermissionsNameInput.tsx
Outdated
Show resolved
Hide resolved
jeff-phillips-18
force-pushed
the
advanced-select
branch
from
542de7c
to
253a4ee
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
Comment on lines
+29
to
+32
| <div>ALL: {biasMetricConfigs.map((c) => c.name).join(', ')}</div> | ||
| <div>UI: {uiSelections}</div> | ||
| <div>current: {currentSelections}</div> | ||
| <div>initialSelections: {initialSelections.map((s) => s.name).join(', ')}</div> |
There was a problem hiding this comment.
Yup, not sure how i missed removing this
There was a problem hiding this comment.
Removing in #3376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RHOAIENG-2404
Description
Remove use of Patternfly deprecated components
How Has This Been Tested?
Tested manually
Test Impact
The following components are effected:
Request review criteria:
Self checklist (all need to be checked):