-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor accelerator profile handling #3342
base: main
Are you sure you want to change the base?
Refactor accelerator profile handling #3342
Conversation
/retest |
1 similar comment
/retest |
564b574
to
b3fc374
Compare
Testing out the accelerator profile dropdown for workbenches, after selecting an accelerator that isn't "None", then creating that workbench, and opening the Edit page for that created workbench afterwards, the previous selected accelerator doesn't seem selected any longer. I checked the main branch and this doesn't seem to be a problem there. |
resetFormData: () => void; | ||
}; | ||
|
||
const useAcceleratorProfileForm = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I know this is a long name already, but FormState
seems more appropriate than just Form
for this name.
@jpuzz0 I found the fix, it was not setting the select field default due to it be async to get the default |
|
bb58105
to
c66c35a
Compare
c66c35a
to
074aafe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and didn't find any issues so far. Left one small comment but that's not very important.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
https://issues.redhat.com/browse/RHOAIENG-13106
Description
This pull request refactors the handling of accelerator profiles and introduces a new custom hook useAcceleratorProfileForm to improve code organization and reusability.
How Has This Been Tested?
Test Impact
none, this is a internal code clarity change
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main