-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to remove all fields within a connection type section #3381
add option to remove all fields within a connection type section #3381
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3381 +/- ##
==========================================
- Coverage 85.08% 85.05% -0.04%
==========================================
Files 1329 1330 +1
Lines 29931 29951 +20
Branches 8200 8204 +4
==========================================
+ Hits 25466 25474 +8
- Misses 4465 4477 +12
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frontend/src/pages/connectionTypes/manage/ConnectionTypeFieldRemoveModal.tsx
is no longer being used since the datafield and section field have separate modals. I think it can be deleted
everything seems to be working good |
563b2ee
to
c1ebdd1
Compare
@emilys314 Gone ahead and removed that file (it actually shows up as a rename now in the change) and also rebased. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-14752
Description
When removing a section, the modal now includes an option to also remove all fields associated to the section; if there are any. Selecting the checkbox will remove the listed fields, otherwise only the section itself is removed.
Also fixed an issue where duplicating a field would add it to the end of the list instead of immediately adjacent to the field you duplicated. This also makes it easier to quickly create fields for testing this issue.
Note that the spacing between the list and the expandable title is the PF default behavior.
How Has This Been Tested?
disableConnectionTypes
Settings -> Connection types
as an adminTest Impact
Added unit tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @simrandhaliw