Apply proper styling for 'Who is my admin?' button and popover content #3389
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3389 +/- ##
==========================================
- Coverage 85.05% 85.02% -0.04%
==========================================
Files 1329 1334 +5
Lines 29930 29956 +26
Branches 8206 8206
==========================================
+ Hits 25458 25471 +13
- Misses 4472 4485 +13
... and 40 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| <Button | ||
| isInline={isInline} | ||
| variant="link" | ||
| icon={<OutlinedQuestionCircleIcon />} | ||
| data-testid={linkTestId} | ||
| > | ||
| {buttonLabel} | ||
| </Button> |
There was a problem hiding this comment.
Requires an aria-label if there's no button label.
Likely always need a label prop and add a separate prop to hide the label.
Closes RHOAIENG-14755
Description
Updates instances of the
Who's my administrator?link and adds it to locations where it is needed.How Has This Been Tested?
As a non-admin who cannot create projects navigate to the following and verify the link:
Need another project?link)Test Impact
There is already a test for this in locations
Screen shots
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main