Skip to content

Commit

Permalink
fix(mr): bug not filling params.env with default cert value (#1457)
Browse files Browse the repository at this point in the history
Signed-off-by: Alessio Pragliola <[email protected]>
  • Loading branch information
Al-Pragliola authored Dec 19, 2024
1 parent 56109a7 commit 198fd71
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions controllers/components/modelregistry/modelregistry.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,8 @@ func (s *componentHandler) GetManagementState(dsc *dscv1.DataScienceCluster) ope
func (s *componentHandler) Init(_ cluster.Platform) error {
mi := baseManifestInfo(BaseManifestsSourcePath)

params := make(map[string]string)
for k, v := range imagesMap {
params[k] = v
}
for k, v := range extraParamsMap {
params[k] = v
}

if err := odhdeploy.ApplyParams(mi.String(), params); err != nil {
return fmt.Errorf("failed to update images on path %s: %w", mi, err)
if err := odhdeploy.ApplyParams(mi.String(), imagesMap, extraParamsMap); err != nil {
return fmt.Errorf("failed to update params on path %s: %w", mi, err)
}

return nil
Expand Down

0 comments on commit 198fd71

Please sign in to comment.