-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update DSC/DSCI .status.release not depend on other's reconcile #1248
fix: update DSC/DSCI .status.release not depend on other's reconcile #1248
Conversation
- when we do not have e.g dependent operators installed, we should have .status.release info as well - previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal" Signed-off-by: Wen Zhou <[email protected]>
@@ -91,7 +91,6 @@ func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.R | |||
r.Log.Error(err, "failed to get operator release version") | |||
return ctrl.Result{}, err | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ac13bee
into
opendatahub-io:incubation
…ed-hat-data-services#1248) - when we do not have e.g dependent operators installed, we should have .status.release info as well - previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal" Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit ac13bee)
…1248) - when we do not have e.g dependent operators installed, we should have .status.release info as well - previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal" Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit ac13bee)
Description
https://issues.redhat.com/browse/RHOAIENG-12630
How Has This Been Tested?
local build:
quay.io/wenzhou/opendatahub-operator-catalog:v2.18.12630
steps:
Screenshot or short clip
Merge criteria