Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update DSC/DSCI .status.release not depend on other's reconcile #1248

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 18, 2024

Description

  • when we do not have e.g dependent operators installed, we should have .status.release info as well
  • previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal"

https://issues.redhat.com/browse/RHOAIENG-12630

How Has This Been Tested?

local build:
quay.io/wenzhou/opendatahub-operator-catalog:v2.18.12630
steps:

  • uninstall ossm operator in the cluster
  • create DSCI with default values
  • wait for seconds to check DSCI has
- status:
  conditions:
    ....
      message: "2 errors occurred:\n\t* failed applying FeatureHandler features. cause: 1 error occurred:\n\t* 1 error occurred:\n\t* failed to find the pre-requisite Service Mesh Operator subscription, please ensure Service Mesh Operator is installed. failed to find the pre-requisite operator subscription \"servicemeshoperator\", please ensure operator is installed. missing operator \"servicemeshoperator\"\n\n\n\n\n\t* failed applying FeatureHandler features. cause: 1 error occurred:\n\t* 1 error occurred:\n\t* failed to find the pre-requisite Service Mesh Operator subscription, please ensure Service Mesh Operator is installed. failed to find the pre-requisite operator subscription \"servicemeshoperator\", please ensure operator is installed. missing operator \"servicemeshoperator\"\n\n\n\n\n\n"
      reason: MissingOperator
      status: 'False'
      type: CapabilityServiceMesh
  phase: Progressing
  release:
    name: Open Data Hub
    version: 2.18.12630
  • create DSC CR with default values
  • wait and check DSC
status:
  components: {}
  conditions:
   .....
  phase: Progressing
  release:
    name: Open Data Hub
    version: 2.18.12630

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- when we do not have e.g dependent operators installed, we should have .status.release info as well
- previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can
  lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal"

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw requested review from andrewballantyne and removed request for adelton September 18, 2024 08:44
@@ -91,7 +91,6 @@ func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.R
r.Log.Error(err, "failed to get operator release version")
return ctrl.Result{}, err
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change

Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ac13bee into opendatahub-io:incubation Sep 18, 2024
8 checks passed
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Sep 25, 2024
…ed-hat-data-services#1248)

- when we do not have e.g dependent operators installed, we should have .status.release info as well
- previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can
  lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal"

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit ac13bee)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Sep 25, 2024
…1248)

- when we do not have e.g dependent operators installed, we should have .status.release info as well
- previous problem is, status update is in the end when reconcile on DSC/DSCI is finished, which can
  lead to a init value 0.0.0 and dashboard set to 0.0.0 to "About Modal"

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit ac13bee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants