Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unnecessary permisison #1250

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 18, 2024

Description

  • trustyai is not needed, has been tested in downstream
  • crd has been covered by group apiextensions.k8s.io
  • we do not need addons.managed.openshift.io for checking managed offerings

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-bundle:v2.18.918

  • create dsci and dsc
  • enable dashboard and trusty, can login dashboard, and no error in operator pod log

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- trustyai is not needed, has been tested in downstream
- crd has been covered by group apiextensions.k8s.io
- we do not need addons.managed.openshift.io for checking managed offerings

Signed-off-by: Wen Zhou <[email protected]>
@openshift-ci openshift-ci bot requested review from asanzgom and grdryn September 18, 2024 14:00
@zdtsw zdtsw requested review from ykaliuta and VaishnaviHire and removed request for grdryn and asanzgom September 18, 2024 14:01
Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Sep 18, 2024

/test opendatahub-operator-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit 5ecadbc into opendatahub-io:incubation Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants