refactor: get platform calls #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move check on platform into top of dsc and dsci reconcile to reduce duplicated calls - add logger when operator start to show which platform is running on Signed-off-by: Wen Zhou <[email protected]>
ykaliuta
approved these changes
Sep 19, 2024
|
will rebase https://github.com/opendatahub-io/opendatahub-operator/pull/1059/files first |
|
Given this change, should we add an explicit testcase in e2e that verifies platform? |
i can add a simple one |
Signed-off-by: Wen Zhou <[email protected]>
updated 4 unit-tests for each case. |
ykaliuta
approved these changes
Sep 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zdtsw
requested review from
VaishnaviHire
and removed request for
lphiri and
gzaronikas
ykaliuta
added a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Sep 23, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (opendatahub-io#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]>
5 tasks
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]>
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 10, 2024
* refactor: get platform calls - move check on platform into top of dsc and dsci reconcile to reduce duplicated calls - add logger when operator start to show which platform is running on - test: add testcase for GetPlatform() --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit d73b3da)
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 10, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (red-hat-data-services#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d6eda01)
5 tasks
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 10, 2024
* refactor: get platform calls - move check on platform into top of dsc and dsci reconcile to reduce duplicated calls - add logger when operator start to show which platform is running on - test: add testcase for GetPlatform() --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit d73b3da)
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 10, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (red-hat-data-services#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d6eda01)
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 17, 2024
* refactor: get platform calls - move check on platform into top of dsc and dsci reconcile to reduce duplicated calls - add logger when operator start to show which platform is running on - test: add testcase for GetPlatform() --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit d73b3da)
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 17, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (red-hat-data-services#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d6eda01)
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 17, 2024
* refactor: get platform calls - move check on platform into top of dsc and dsci reconcile to reduce duplicated calls - add logger when operator start to show which platform is running on - test: add testcase for GetPlatform() --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit d73b3da)
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 17, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (red-hat-data-services#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d6eda01)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Oct 17, 2024
* refactor: get platform calls - move check on platform into top of dsc and dsci reconcile to reduce duplicated calls - add logger when operator start to show which platform is running on - test: add testcase for GetPlatform() --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit d73b3da)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Oct 17, 2024
There is no need to maintain the api since GetRelease performs the call and returns the information. The extra work GetRelease does (in addition to GetPlatform) is not important since only one call in startup left. Since the api removed, tests do not make sense, so revert testing part of d73b3da ("refactor: get platform calls (#1251)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d6eda01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(split from [RFC] feat: pass platform from env variable and fall back to use old logic #1231)
How Has This Been Tested?
local build: quay.io/wenzhou/opendatahub-operator:2.18.919-1
Screenshot or short clip
Merge criteria