Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce more call to get platform #1255

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 23, 2024

Description

  • we have get the Release can derive info from it.
  • rename variable to be clear not only version but also name/platform

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- we have get the Release can derive info from it.

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw requested review from ykaliuta and VaishnaviHire and removed request for AjayJagan and jackdelahunt September 23, 2024 08:58
@ykaliuta
Copy link
Contributor

removing calls and renaming the variable are two unrelated to each other changes, right?

@zdtsw
Copy link
Member Author

zdtsw commented Sep 23, 2024

removing calls and renaming the variable are two unrelated to each other changes, right?

removing calls is the init idea
but since it gets the filed Name from variable, the renaming comes into place.
i can keep the variable with old name with following PR, but sounds strange to do a currentOperatorReleaseVersion.Name here

Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8d3a6c2 into opendatahub-io:incubation Sep 23, 2024
8 checks passed
@ykaliuta
Copy link
Contributor

ykaliuta commented Sep 23, 2024

Basically we can remove GetPlatform API completely

zdtsw referenced this pull request in zdtsw-forking/rhods-operator Oct 10, 2024
- we have get the Release can derive info from it.

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 8d3a6c2)
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Oct 10, 2024
- we have get the Release can derive info from it.

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 8d3a6c2)
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Oct 17, 2024
- we have get the Release can derive info from it.

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 8d3a6c2)
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Oct 17, 2024
- we have get the Release can derive info from it.

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 8d3a6c2)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Oct 17, 2024
- we have get the Release can derive info from it.

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 8d3a6c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants