feat: add support for upgrade to force disableModelRegistry to false #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
ykaliuta,
andrewballantyne and
VaishnaviHire
and removed request for
lphiri and
ajaypratap003
lburgazzoli
reviewed
Oct 1, 2024
pkg/upgrade/upgrade.go
Outdated
| } | ||
| return nil | ||
| } | ||
| ctrl.Log.Info("Upgrade does not force BiasMetrics to false due to from release >= 2.14.0") |
- seems duplicate to create a new function but mainly: - can have a different value for the version - if we want to keep one and remove another just comment out function - probably we will have some other with similar logic later till it can be done in UI logic Signed-off-by: Wen Zhou <[email protected]>
ykaliuta
approved these changes
Oct 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1a441e7
into
opendatahub-io:incubation
8 checks passed
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 1, 2024
…ed-hat-data-services#1269) - seems duplicate to create a new function but mainly: - can have a different value for the version - if we want to keep one and remove another just comment out function - probably we will have some other with similar logic later till it can be done in UI logic Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 1a441e7)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Oct 1, 2024
…1269) - seems duplicate to create a new function but mainly: - can have a different value for the version - if we want to keep one and remove another just comment out function - probably we will have some other with similar logic later till it can be done in UI logic Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 1a441e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://issues.redhat.com/browse/RHOAIENG-13604
How Has This Been Tested?
local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.14.13604
For ODH case
disableModelRegistry: truedisableModelRegistry: trueFor downstream case
disableModelRegistry: truedisableModelRegistry: falseScreenshot or short clip
Merge criteria