Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: monitoring stack only apply if it is managed cluster + do not create monitoring namespace for non-Managed offering #1321

Open
wants to merge 1 commit into
base: incubation
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 28, 2024

Description

  • keep managed cluster logic as-is
  • create redhat-ods-monitoring namespace only for managed cluster if dsci set monitoring to enabled (in most case / default case this will be enabled)
  • remove existing role rolebinding and servicemonitor during upgrade if it is self-managed : as cleanup from previous releases
  • keep redhat-ods-monitroing namespace in self-managed if it has been created from previous release
  • do not apply role rolebinding networkpolicy and servicemonitor in clean install for self-managed, should only be done if it is managed cluster

ref: https://issues.redhat.com/browse/RHOAIENG-2761

partially related to https://issues.redhat.com/browse/RHOAIRFE-422
so we do not need to consider monitoring case

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from etirelli and grdryn October 28, 2024 17:12
Copy link

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (incubation@0b4b1f4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
controllers/dscinitialization/utils.go 0.00% 7 Missing and 1 partial ⚠️
.../dscinitialization/dscinitialization_controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             incubation    #1321   +/-   ##
=============================================
  Coverage              ?   18.28%           
=============================================
  Files                 ?       30           
  Lines                 ?     3391           
  Branches              ?        0           
=============================================
  Hits                  ?      620           
  Misses                ?     2703           
  Partials              ?       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdtsw zdtsw changed the title update: monitoring stack only apply if it is managed cluster update: monitoring stack only apply if it is managed cluster + do not create monitoring namespace for non-Managed offering Nov 15, 2024
@zdtsw zdtsw force-pushed the jira/2761_2 branch 2 times, most recently from e3999a6 to ba2d0e9 Compare November 15, 2024 11:25
@zdtsw zdtsw removed the odh-2.21 label Nov 15, 2024
@VaishnaviHire
Copy link
Member

Do we know if other components do not reference or use this in self-managed as part of workload-monitoring?

@zdtsw
Copy link
Member Author

zdtsw commented Nov 16, 2024

Do we know if other components do not reference or use this in self-managed as part of workload-monitoring?

i do not believe any component is using redhat-ods-monitoring namespace but let me get confirm from teams first.

@zdtsw
Copy link
Member Author

zdtsw commented Nov 18, 2024

Do we know if other components do not reference or use this in self-managed as part of workload-monitoring?

asked here: https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1731914889336659
component confirmed they do not use it

@zdtsw zdtsw force-pushed the jira/2761_2 branch 2 times, most recently from 9f3fbe3 to f118a6a Compare December 2, 2024 10:13
- keep managed cluster logic as-is
- create redhat-ods-monitoring namespace only in managed if dsic set monitoring to enabled
- do not create redhat-ods-monitoring namespace in self-managed any more even monitoring is enabled
- remove role rolebinding and servicemonitor in upgrade for self-managed
- do not apply role rolebinding networkpoliy and servicemonitor for monitoring in clean install for self-managed

Signed-off-by: Wen Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants