-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: monitoring stack only apply if it is managed cluster + do not create monitoring namespace for non-Managed offering #1321
base: incubation
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## incubation #1321 +/- ##
=============================================
Coverage ? 18.28%
=============================================
Files ? 30
Lines ? 3391
Branches ? 0
=============================================
Hits ? 620
Misses ? 2703
Partials ? 68 ☔ View full report in Codecov by Sentry. |
e3999a6
to
ba2d0e9
Compare
Do we know if other components do not reference or use this in self-managed as part of workload-monitoring? |
i do not believe any component is using |
asked here: https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1731914889336659 |
9f3fbe3
to
f118a6a
Compare
- keep managed cluster logic as-is - create redhat-ods-monitoring namespace only in managed if dsic set monitoring to enabled - do not create redhat-ods-monitoring namespace in self-managed any more even monitoring is enabled - remove role rolebinding and servicemonitor in upgrade for self-managed - do not apply role rolebinding networkpoliy and servicemonitor for monitoring in clean install for self-managed Signed-off-by: Wen Zhou <[email protected]>
Description
redhat-ods-monitoring
namespace only for managed cluster if dsci set monitoring to enabled (in most case / default case this will be enabled)ref: https://issues.redhat.com/browse/RHOAIENG-2761
partially related to https://issues.redhat.com/browse/RHOAIRFE-422
so we do not need to consider monitoring case
How Has This Been Tested?
Screenshot or short clip
Merge criteria