Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ModelRegistry component API and reconciler #1337

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Nov 1, 2024

Description

https://issues.redhat.com/browse/RHOAIENG-13184

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from CFSNM and grdryn November 1, 2024 18:10
@lburgazzoli lburgazzoli force-pushed the RHOAIENG-13184-model-registry branch 7 times, most recently from 6400a60 to 69e62d4 Compare November 4, 2024 07:14
@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

1 similar comment
@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-13184-model-registry branch 2 times, most recently from 33338c3 to a52346b Compare November 4, 2024 14:46
@grdryn
Copy link
Member

grdryn commented Nov 4, 2024

/lgtm cancel

Probably someone else should review and add one of the labels :)

@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@e273140). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/cluster/cert.go 0.00% 10 Missing ⚠️
...atasciencecluster/datasciencecluster_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1337   +/-   ##
============================================================
  Coverage                             ?   24.45%           
============================================================
  Files                                ?       52           
  Lines                                ?     4286           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1048           
  Misses                               ?     3109           
  Partials                             ?      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-13184-model-registry branch from ddf3667 to 5f888da Compare November 5, 2024 06:58
@lburgazzoli lburgazzoli requested a review from zdtsw November 5, 2024 11:26
@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2024
Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c8df75f into opendatahub-io:feature-operator-refactor Nov 5, 2024
10 checks passed
@lburgazzoli lburgazzoli deleted the RHOAIENG-13184-model-registry branch November 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants