Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique alert names #1397

Merged

Conversation

jackdelahunt
Copy link
Contributor

@jackdelahunt jackdelahunt commented Nov 27, 2024

Jira: https://issues.redhat.com/browse/RHOAIENG-16229

Description

Give unique names to alerts to give more info about what is firing

How Has This Been Tested?

make test-alerts

Screenshot or short clip

image

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (rhoai@55fd878). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             rhoai    #1397   +/-   ##
========================================
  Coverage         ?   18.87%           
========================================
  Files            ?       30           
  Lines            ?     3338           
  Branches         ?        0           
========================================
  Hits             ?      630           
  Misses           ?     2639           
  Partials         ?       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdtsw zdtsw requested review from grdryn and removed request for ajaypratap003 November 27, 2024 18:55
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks reasonable to me, will leave it to @StevenTobin or others to approve, since they may have more context on the reason for the change, etc.

@StevenTobin
Copy link
Contributor

/lgtm

@jackdelahunt
Copy link
Contributor Author

Added the changes needs for rhods after rebase, and also had to sign commits so need lgtm again

Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2024
Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grdryn
Copy link
Member

grdryn commented Nov 28, 2024

and also had to sign commits

Is that a requirement?

@openshift-merge-bot openshift-merge-bot bot merged commit 76cae1b into opendatahub-io:rhoai Nov 28, 2024
11 checks passed
@jackdelahunt
Copy link
Contributor Author

and also had to sign commits

Is that a requirement?

When I was making a pr into the component refactor it wasn't but for this branch it is apparently.

Not sure if it is new or just for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants