-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique alert names #1397
Unique alert names #1397
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1397 +/- ##
========================================
Coverage ? 18.87%
========================================
Files ? 30
Lines ? 3338
Branches ? 0
========================================
Hits ? 630
Misses ? 2639
Partials ? 69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks reasonable to me, will leave it to @StevenTobin or others to approve, since they may have more context on the reason for the change, etc.
/lgtm |
afe96e7
to
9f8b915
Compare
d69a84f
to
9882437
Compare
9882437
to
feb5838
Compare
Added the changes needs for rhods after rebase, and also had to sign commits so need lgtm again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is that a requirement? |
76cae1b
into
opendatahub-io:rhoai
When I was making a pr into the component refactor it wasn't but for this branch it is apparently. Not sure if it is new or just for this |
Jira: https://issues.redhat.com/browse/RHOAIENG-16229
Description
Give unique names to alerts to give more info about what is firing
How Has This Been Tested?
make test-alerts
Screenshot or short clip
Merge criteria